diff options
| author | Crystal Lin <crystal_lin@compal.corp-partner.google.com> | 2018-06-21 16:29:33 +0800 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2018-06-25 16:36:14 +0000 |
| commit | 3ff98ca858db99511c1e6ab97be09c5e7f6b21d4 (patch) | |
| tree | 6312dd11b059cbf39e40bdfdc6b4d73196eeb7c6 /src | |
| parent | 39ac797eda2563c164624f8be142605d4ff4a029 (diff) | |
mb/google/poppy/variants/nami: Prevent leakage with touchscreen on Pantheon
We found GPP_C3 keeps high when system in S0ix mode. It caused 1.8V
leakage. To fix this problem, add GPP_C3 into config for Pantheon
Synaptics touchscreen.
BUG=b:78436458
BRANCH=None
TEST=Let DUT in S0ix mode and check GPP_C3 is normal.
Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af
Signed-off-by: Crystal Lin <crystal_lin@compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/27177
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/google/poppy/variants/nami/gpio.c | 22 |
1 files changed, 17 insertions, 5 deletions
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index 3c82c2b7d1..2d0fea4955 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -118,8 +118,6 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2 : SMBALERT# ==> NC(TP917) */ PAD_CFG_NC(GPP_C2), - /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ - PAD_CFG_GPO(GPP_C3, 0, DEEP), /* C4 : SML0DATA ==> NC */ PAD_CFG_NC(GPP_C4), /* C5 : SML0ALERT# ==> SOC_SML0ALERT# (unstuffed) */ @@ -389,11 +387,22 @@ const struct pad_config *variant_early_gpio_table(size_t *num) static const struct pad_config nami_default_sku_gpio_table[] = { /* D17 : DMIC_CLK1 ==> SOC_DMIC_CLK1 */ PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1), + /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ + PAD_CFG_GPO(GPP_C3, 0, DEEP), }; static const struct pad_config no_dmic1_sku_gpio_table[] = { /* D17 : DMIC_CLK1 ==> NC */ PAD_CFG_NC(GPP_D17), + /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ + PAD_CFG_GPO(GPP_C3, 0, DEEP), +}; + +static const struct pad_config pantheon_gpio_table[] = { + /* D17 : DMIC_CLK1 ==> NC */ + PAD_CFG_NC(GPP_D17), + /* C3 : SML0CLK ==> NC */ + PAD_CFG_NC(GPP_C3), }; const struct pad_config *variant_sku_gpio_table(size_t *num) @@ -404,14 +413,17 @@ const struct pad_config *variant_sku_gpio_table(size_t *num) case SKU_0_VAYNE: case SKU_1_VAYNE: case SKU_2_VAYNE: - case SKU_0_PANTHEON: - case SKU_1_PANTHEON: - case SKU_2_PANTHEON: case SKU_0_SONA: case SKU_1_SONA: *num = ARRAY_SIZE(no_dmic1_sku_gpio_table); board_gpio_tables = no_dmic1_sku_gpio_table; break; + case SKU_0_PANTHEON: + case SKU_1_PANTHEON: + case SKU_2_PANTHEON: + *num = ARRAY_SIZE(pantheon_gpio_table); + board_gpio_tables = pantheon_gpio_table; + break; default: *num = ARRAY_SIZE(nami_default_sku_gpio_table); board_gpio_tables = nami_default_sku_gpio_table; |