diff options
| author | Martin Roth <martinroth@google.com> | 2016-07-25 16:14:25 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-07-28 19:22:35 +0200 |
| commit | 2098778726a209b3a9465b203a3fdb72c45706c0 (patch) | |
| tree | 13c1960970859304dd92b915e3655819aa1ba270 /src | |
| parent | 8e63017096e23a962bc017a6c0503dddc57f63e3 (diff) | |
intel/common/opregion.c: only write 16 bytes to 16 byte field
Including the terminating null, 17 characters were being written to the
field, overwriting the a byte of the size field.
Fortunately, the size was updated soon after this.
Fixes coverity warning 1229570 - Destination buffer too small.
Change-Id: I39285a9283dd9a17d638afe5b2755c7e420d7698
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/15889
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/intel/common/opregion.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/common/opregion.c b/src/soc/intel/common/opregion.c index fa4d604a42..44c27fb8fa 100644 --- a/src/soc/intel/common/opregion.c +++ b/src/soc/intel/common/opregion.c @@ -40,7 +40,7 @@ int init_igd_opregion(igd_opregion_t *opregion) memset(opregion, 0, sizeof(igd_opregion_t)); memcpy(&opregion->header.signature, IGD_OPREGION_SIGNATURE, - sizeof(IGD_OPREGION_SIGNATURE)); + sizeof(opregion->header.signature)); memcpy(opregion->header.vbios_version, vbt->coreblock_biosbuild, ARRAY_SIZE(vbt->coreblock_biosbuild)); memcpy(opregion->vbt.gvd1, vbt, MIN(vbt->hdr_vbt_size, |