diff options
| author | Marc Jones <marcj303@gmail.com> | 2018-08-15 22:17:45 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-08-17 21:09:17 +0000 |
| commit | 1faa11ed392d70bedbbe7443401e9259f216e0b6 (patch) | |
| tree | d9f882a94f84bd7dcd6124582cc14c8dbbc2e114 /src | |
| parent | 4988fe2986078a8d8f87f5683ee3c820655895ca (diff) | |
Fix PCI ACPI _OSC methods
Fix the IASL build warnings:
Object is not referenced (Name [CDW2] is within a method [_OSC])
Object is not referenced (Name [CDW3] is within a method [_OSC])
Remove the not referenced objects. They are not needed.
BUG=b:112476331
TEST=IASL doesn't give the warning.
Change-Id: I5b38d4de3f9875c5b013a49eb5146bf5916b96a6
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: https://review.coreboot.org/28121
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/northbridge/intel/i945/acpi/i945.asl | 6 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl | 6 | ||||
| -rw-r--r-- | src/southbridge/amd/agesa/hudson/acpi/fch.asl | 6 | ||||
| -rw-r--r-- | src/southbridge/amd/cimx/sb800/acpi/fch.asl | 6 | ||||
| -rw-r--r-- | src/southbridge/amd/pi/hudson/acpi/fch.asl | 6 |
5 files changed, 5 insertions, 25 deletions
diff --git a/src/northbridge/intel/i945/acpi/i945.asl b/src/northbridge/intel/i945/acpi/i945.asl index 5a932385d0..79fb371250 100644 --- a/src/northbridge/intel/i945/acpi/i945.asl +++ b/src/northbridge/intel/i945/acpi/i945.asl @@ -20,17 +20,13 @@ /* Operating System Capabilities Method */ Method (_OSC, 4) { - // Create DWord-addressable fields from the Capabilities Buffer - CreateDWordField(Arg3, 0, CDW1) - CreateDWordField(Arg3, 4, CDW2) - CreateDWordField(Arg3, 8, CDW3) - /* Check for proper PCI/PCIe UUID */ If (LEqual(Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) { /* Let OS control everything */ Return(Arg3) } Else { + CreateDWordField(Arg3, 0, CDW1) Or(CDW1, 4, CDW1) // Unrecognized UUID, so set bit 2 to 1 Return(Arg3) } diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl index 2855b23fab..cdda5032b4 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl @@ -22,17 +22,13 @@ External(\_SB.ALIB, MethodObj) /* Operating System Capabilities Method */ Method(_OSC,4) { - // Create DWord-addressable fields from the Capabilities Buffer - CreateDWordField(Arg3,0,CDW1) - CreateDWordField(Arg3,4,CDW2) - CreateDWordField(Arg3,8,CDW3) - /* Check for proper PCI/PCIe UUID */ If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) { /* Let OS control everything */ Return (Arg3) } Else { + CreateDWordField(Arg3,0,CDW1) Or(CDW1,4,CDW1) // Unrecognized UUID Return(Arg3) } diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl index efd6a9348c..2bbaa2538c 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl @@ -20,17 +20,13 @@ /* Operating System Capabilities Method */ Method(_OSC,4) { - // Create DWord-addressable fields from the Capabilities Buffer - CreateDWordField(Arg3,0,CDW1) - CreateDWordField(Arg3,4,CDW2) - CreateDWordField(Arg3,8,CDW3) - /* Check for proper PCI/PCIe UUID */ If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) { /* Let OS control everything */ Return (Arg3) } Else { + CreateDWordField(Arg3,0,CDW1) Or(CDW1,4,CDW1) // Unrecognized UUID Return(Arg3) } diff --git a/src/southbridge/amd/cimx/sb800/acpi/fch.asl b/src/southbridge/amd/cimx/sb800/acpi/fch.asl index 6f0826fee4..2dc3438c08 100644 --- a/src/southbridge/amd/cimx/sb800/acpi/fch.asl +++ b/src/southbridge/amd/cimx/sb800/acpi/fch.asl @@ -19,17 +19,13 @@ /* Operating System Capabilities Method */ Method(_OSC,4) { - // Create DWord-addressable fields from the Capabilities Buffer - CreateDWordField(Arg3,0,CDW1) - CreateDWordField(Arg3,4,CDW2) - CreateDWordField(Arg3,8,CDW3) - /* Check for proper PCI/PCIe UUID */ If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) { /* Let OS control everything */ Return (Arg3) } Else { + CreateDWordField(Arg3,0,CDW1) Or(CDW1,4,CDW1) // Unrecognized UUID Return(Arg3) } diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl index 2586dd4810..b33a440548 100644 --- a/src/southbridge/amd/pi/hudson/acpi/fch.asl +++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl @@ -20,17 +20,13 @@ /* Operating System Capabilities Method */ Method(_OSC,4) { - // Create DWord-addressable fields from the Capabilities Buffer - CreateDWordField(Arg3,0,CDW1) - CreateDWordField(Arg3,4,CDW2) - CreateDWordField(Arg3,8,CDW3) - /* Check for proper PCI/PCIe UUID */ If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) { /* Let OS control everything */ Return (Arg3) } Else { + CreateDWordField(Arg3,0,CDW1) Or(CDW1,4,CDW1) // Unrecognized UUID Return(Arg3) } |