diff options
| author | Jonas Moehle <ad-min@mailbox.org> | 2019-12-25 20:04:46 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-01-11 11:12:32 +0000 |
| commit | bece6e86dd93e51624c97a9eaec2de0d8b76b9b2 (patch) | |
| tree | 6eeea65b8cf8472d9a189ac68ed87bd916e2e8fd /src | |
| parent | 11c5b3b180b92fd32826c617bad3f99722223d48 (diff) | |
src/mainboard/*.asl: Remove _HID / _ADR objects overlapping
ACPI spec:
"A device object must contain either an _HID object or an _ADR
object, but should not contain both."
Signed-off-by: Jonas Moehle <ad-min@mailbox.org>
Change-Id: I949393558f5af66689c167b2e593a1461f641962
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37935
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
3 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl index e3f2e5f7f1..ccaa6e3118 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl @@ -18,7 +18,6 @@ /* I/O APIC id 0x3 */ Device(PBIO) { - Name (_HID, "ACPI000A") Name (_ADR, 0x001c0000) } @@ -59,7 +58,6 @@ Device(P64B) /* I/O APIC id 0x4 */ Device(PAIO) { - Name (_HID, "ACPI000A") Name (_ADR, 0x001e0000) } diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl index 01942dcbd3..9b88cdd517 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl @@ -18,7 +18,6 @@ /* Grunt specific I2S machine driver */ Device (I2S) { - Name (_ADR, 1) Name (_HID, "AMD7219") Name (_CID, "AMD7219") diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl index 1d5437bbf2..caaae86b95 100644 --- a/src/mainboard/intel/strago/acpi/mainboard.asl +++ b/src/mainboard/intel/strago/acpi/mainboard.asl @@ -114,7 +114,7 @@ Scope (\_SB.PCI0.I2C5) /* Realtek Audio Codec */ Device (RTEK) /* Audio Codec driver I2C */ { - Name (_ADR, 0) + Name (_HID, AUDIO_CODEC_HID) Name (_CID, AUDIO_CODEC_CID) Name (_DDN, AUDIO_CODEC_DDN) |