diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-09-05 13:18:32 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2024-09-07 08:25:54 +0000 |
| commit | ef386e076849d3e0da41d013d640185e82c00d1a (patch) | |
| tree | 32989f1de6d74f4c760c3f463896b5084669f867 /src | |
| parent | 9947d545774946f75a432e75ef09aa7805fbb0d4 (diff) | |
drivers/intel/fsp2_0: Consolidate `BUILDING_WITH_DEBUG_FSP` option
Move the `BUILDING_WITH_DEBUG_FSP` Kconfig option from SoC-specific
files to the FSP2_0 driver Kconfig to avoid duplication. Also slightly
improves the option's prompt and help text.
TEST=Built and booted google/rex successfully.
Change-Id: I5c3dce59c396f6c1665a3ed1b8c1bb5df0f5a8d4
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84220
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/drivers/intel/fsp2_0/Kconfig | 7 | ||||
| -rw-r--r-- | src/soc/intel/alderlake/Kconfig | 6 | ||||
| -rw-r--r-- | src/soc/intel/meteorlake/Kconfig | 6 | ||||
| -rw-r--r-- | src/soc/intel/pantherlake/Kconfig | 6 |
4 files changed, 7 insertions, 18 deletions
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index bbf0710b7f..8e9dcdc4dc 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -533,4 +533,11 @@ config FSP_PUBLISH_MBP_HOB ChromeOS devices typically do not require the MBP information, hence it is disabled by default on ChromeOS. +config BUILDING_WITH_DEBUG_FSP + bool "Use Debug FSP for Build" + default n + help + Enable this option if you are using a debug build of the FSP (Firmware Support Package) + in your project. + endif diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index c1cc993efb..2c441fc398 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -493,12 +493,6 @@ config SI_DESC_REGION_SZ help Size of Descriptor Region in the FMAP -config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - config INTEL_GMA_BCLV_OFFSET default 0xc8258 diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 753af7cb67..b5c0bcf3cc 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -380,12 +380,6 @@ config SOC_INTEL_GFX_FRAMEBUFFER_OFFSET hex default 0x800000 -config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - config DROP_CPU_FEATURE_PROGRAM_IN_FSP bool default y if MP_SERVICES_PPI_V2_NOOP || CHROMEOS diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig index e5f7c9201e..98248fe955 100644 --- a/src/soc/intel/pantherlake/Kconfig +++ b/src/soc/intel/pantherlake/Kconfig @@ -242,10 +242,4 @@ config MRC_CHANNEL_WIDTH int default 16 -config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - endif |