diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2021-10-01 20:11:45 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-12 20:15:14 +0000 |
| commit | e240f8761f6ffb4bad8582a740a9a2aa25cd2c97 (patch) | |
| tree | a69d6c360eb80963e4ab4915e72131dea8d0faa0 /src | |
| parent | d2fadda52a5df72dbaedeed5c7f1c94bedbfd898 (diff) | |
soc/amd/common/block/include/psp_efs: use unsigned type for bitfield
For 1 bit long bit fields an unsigned type should be used. In this case
uint32_t is used instead of a generic unsigned int for both consistency
reasons with the rest of the file and to clarify that the bits will be
packed into a 32 bit memory location.
TEST=Resulting image of a timeless build for google/guybrush results in
identical binary.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic630d1709174d90336746bc37da504437c12643c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58224
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/common/block/include/amdblocks/psp_efs.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/include/amdblocks/psp_efs.h b/src/soc/amd/common/block/include/amdblocks/psp_efs.h index 7afd295df3..77da70a06f 100644 --- a/src/soc/amd/common/block/include/amdblocks/psp_efs.h +++ b/src/soc/amd/common/block/include/amdblocks/psp_efs.h @@ -26,8 +26,8 @@ struct second_gen_efs { /* todo: expand for Server products */ - int gen:1; /* Client products only use bit 0 */ - int reserved:31; + uint32_t gen:1; /* Client products only use bit 0 */ + uint32_t reserved:31; } __attribute__((packed)); /* Copied from coreboot/util/amdfwtool.h */ |