diff options
| author | Sridhar Siricilla <sridhar.siricilla@intel.com> | 2022-04-29 15:13:38 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-05-25 18:56:08 +0000 |
| commit | db8a97a0e01fd87ab3f8e6893f8e0ccf98986e27 (patch) | |
| tree | 59f1ee336f32be72c516a8937e4d28afac27529e /src | |
| parent | 616c07c87f3e7acdab2ec10fc95579cf53fca3a6 (diff) | |
soc/intel/common: Skip sending DISCONNECT IPC command
The patch skips sending DISCONNECT IPC command to PMC if system resumes
from S3.
coreboot notice DISCONNECT IPC command getting timedout during S3
resume if system has AC connected behind Type-C hub. This impacts
system resume time. Please refer TA# 730910 for more information.
coreboot need not send the DISCONNECT IPC command when system resumes
from S3 state.
TEST=Verified system boots to OS and verfied below tests on Gimble
1. coreboot doesn't send the DISCONNECT during S3 resume
2. After S3 resume, system detects the pen drive with Superspeed
3. After system resumes from S3, hot-plug the pen drive, system detects
the pen drive
3. System sends IPC commands when system boots from S0 or S5.
Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I6ad006ae8677919c7dfeca8eec0af11454a2e89d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63932
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/intel/common/block/tcss/tcss.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 18fff20fb2..a0cd733ad7 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -422,8 +422,10 @@ void tcss_configure(const struct typec_aux_bias_pads aux_bias_pads[MAX_TYPE_C_PO if (port_map == NULL) return; - for (i = 0; i < num_ports; i++) - tcss_init_mux(i, &port_map[i]); + if (!platform_is_resuming()) { + for (i = 0; i < num_ports; i++) + tcss_init_mux(i, &port_map[i]); + } /* This should be performed before alternate modes are entered */ if (tcss_ops.configure_aux_bias_pads) |