summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2017-07-04 17:10:37 -0500
committerFelix Held <felix-coreboot@felixheld.de>2023-08-10 12:38:24 +0000
commitdb20a08b654ad15715926857dd9c4d52eef0ac45 (patch)
tree7c8b6afbf7826ac4816bbb45d22936a90b676577 /src
parent8757b23ae940800f34ecdc3d040a14587ead97ac (diff)
mb/google/cyan: Guard I2C devices as wake sources with CONFIG_CHROMEOS
The use of a separate _PRW is not necessary when the _CRS interrupt already has the Wake flag set (as these all do). Additionally, Windows does not allow the use of a gpioint for the _PRW source, which results in an ACPI_BIOS_ERROR BSOD. Since ChromeOS builds for CYAN devices use an older kernel and may not make use of _CRS interrupt Wake flag, keep the _PRW around when CONFIG_CHROMEOS is selected. TEST=build/boot Win11 on google/{cyan,edgar} Change-Id: I7d0883e4de9572a14c8bad0ac086370bd00eeb1a Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76798 Reviewed-by: CoolStar <coolstarorganization@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/google/cyan/acpi/touchscreen_elan.asl4
-rw-r--r--src/mainboard/google/cyan/acpi/touchscreen_melfas.asl4
-rw-r--r--src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl4
-rw-r--r--src/mainboard/google/cyan/acpi/trackpad_atmel.asl3
-rw-r--r--src/mainboard/google/cyan/acpi/trackpad_elan.asl4
5 files changed, 10 insertions, 9 deletions
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
index 14e5135425..312c1a800d 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl
@@ -35,9 +35,9 @@ Scope (\_SB.PCI0.I2C1)
Return (0x0)
}
}
-
+#if CONFIG(CHROMEOS)
Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
-
+#endif
/* Allow device to power off in S0 */
Name (_S0W, 4)
}
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
index 6fc1e107d4..4aa39961b5 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl
@@ -34,9 +34,9 @@ Scope (\_SB.PCI0.I2C1)
Return (0x0)
}
}
-
+#if CONFIG(CHROMEOS)
Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
-
+#endif
/* Allow device to power off in S0 */
Name (_S0W, 4)
}
diff --git a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
index 02b4db3e9d..aa1446a3e6 100644
--- a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
+++ b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl
@@ -76,9 +76,9 @@ Scope (\_SB.PCI0.I2C1)
Return (0x0)
}
}
-
+#if CONFIG(CHROMEOS)
Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
-
+#endif
/* Allow device to power off in S0 */
Name (_S0W, 4)
}
diff --git a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
index 43180a2bea..cc0ecd45f0 100644
--- a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
+++ b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl
@@ -8,8 +8,9 @@ Scope (\_SB.PCI0.I2C6)
Name (_DDN, "Atmel Touchpad")
Name (_UID, 2)
Name (ISTP, 1) /* Touchpad */
+#if CONFIG(CHROMEOS)
Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
-
+#endif
Name (_CRS, ResourceTemplate()
{
I2cSerialBus (
diff --git a/src/mainboard/google/cyan/acpi/trackpad_elan.asl b/src/mainboard/google/cyan/acpi/trackpad_elan.asl
index 93cda3477f..b767c372be 100644
--- a/src/mainboard/google/cyan/acpi/trackpad_elan.asl
+++ b/src/mainboard/google/cyan/acpi/trackpad_elan.asl
@@ -30,9 +30,9 @@ Scope (\_SB.PCI0.I2C6)
Return (0x0)
}
}
-
+#if CONFIG(CHROMEOS)
Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
-
+#endif
/* Allow device to power off in S0 */
Name (_S0W, 4)
}