diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2023-04-19 14:48:51 +0100 |
|---|---|---|
| committer | Lean Sheng Tan <sheng.tan@9elements.com> | 2023-04-29 19:45:06 +0000 |
| commit | cd48c7ece3d38acaf67d25e35b1a66a47728aec8 (patch) | |
| tree | e75d48432a783faaa67dfe31ab3e03eb76e0ddd0 /src | |
| parent | 5fc0afbc170960d05012eec9b3b8717f65a07478 (diff) | |
mb/starlabs/starbook: Let coreboot configure ASPM
FSP is fractionally faster at configuring ASPM (1,118,688 vs 1,122,205)
but coreboot's configuration results in lower power consumption of
approximately 0.5W when idling - the reason why is unknown.
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Ib15eaede956f0aa55118d093fdff0fd9487df250
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74520
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/starlabs/starbook/Kconfig | 21 | ||||
| -rw-r--r-- | src/mainboard/starlabs/starbook/variants/adl/devicetree.cb | 4 |
2 files changed, 0 insertions, 25 deletions
diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 5ad7e2747f..b49a86d4b3 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -147,30 +147,9 @@ config EDK2_BOOTSPLASH_FILE string default "3rdparty/blobs/mainboard/starlabs/Logo.bmp" -config PCIEXP_ASPM - bool - default n - help - FSP is already taking care of ASPM, which is configured through the devicetree in coreboot - on Alderlake Platforms. Disable it to save some boot time. - config PCIEXP_DEFAULT_MAX_RESIZABLE_BAR_BITS default 32 -config PCIEXP_L1_SUB_STATE - bool - default n - help - Enabling PCIe L1 sub states is already done in FSP. - Disable it to save some boot time. - -config PCIEXP_CLK_PM - bool - default n - help - Enabling PCIe clock power management is already done in FSP. - Disable it to save some boot time - config SOC_INTEL_CSE_SEND_EOP_EARLY default n if BOARD_STARLABS_STARBOOK_ADL diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 5c54f4da35..298ec199b2 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -100,8 +100,6 @@ chip soc/intel/alderlake .clk_src = 2, .clk_req = 2, .flags = PCIE_RP_LTR | PCIE_RP_AER, - .PcieRpL1Substates = L1_SS_L1_2, - .pcie_rp_aspm = ASPM_L0S_L1, }" smbios_slot_desc "SlotTypePciExpressGen3X1" "SlotLengthShort" @@ -119,8 +117,6 @@ chip soc/intel/alderlake .clk_src = 1, .clk_req = 1, .flags = PCIE_RP_LTR | PCIE_RP_AER, - .PcieRpL1Substates = L1_SS_L1_2, - .pcie_rp_aspm = ASPM_L0S_L1, }" smbios_slot_desc "SlotTypeM2Socket3" |