diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-07-17 22:59:02 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-07-18 21:51:33 +0000 |
| commit | c04d3ddbaef84746e6651e7354a81b874dbd3385 (patch) | |
| tree | f17936968325e6c2af6de9f9aad0cba82cbac6c4 /src | |
| parent | 8e0bbb30b616fe65bb03186220753af76dfda7d2 (diff) | |
include/cpu/amd/msr: introduce and use PSTATE_MSR_COUNT
Add and use a define for the total number of P-state MSRs to avoid magic
constants in the code.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I37a89faa0f216790b3404fc03edc62408684cc24
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76546
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/cpu/amd/msr.h | 1 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/pstate_util.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/include/cpu/amd/msr.h b/src/include/cpu/amd/msr.h index ccc9719cb6..3f7febc462 100644 --- a/src/include/cpu/amd/msr.h +++ b/src/include/cpu/amd/msr.h @@ -41,6 +41,7 @@ #define PS_STS_REG 0xC0010063 #define PSTATE_0_MSR 0xC0010064 #define PSTATE_MSR(pstate) (PSTATE_0_MSR + (pstate)) +#define PSTATE_MSR_COUNT 8 #define MSR_PATCH_LOADER 0xC0010020 diff --git a/src/soc/amd/stoneyridge/pstate_util.c b/src/soc/amd/stoneyridge/pstate_util.c index 12bc2b5cfa..cd5878f82a 100644 --- a/src/soc/amd/stoneyridge/pstate_util.c +++ b/src/soc/amd/stoneyridge/pstate_util.c @@ -21,7 +21,7 @@ static bool all_pstates_have_same_frequency_id(void) bool first = true; uint32_t frequency_id; - for (i = 0; i < 8; i++) { + for (i = 0; i < PSTATE_MSR_COUNT; i++) { pstate_reg.raw = rdmsr(PSTATE_MSR(i)).raw; if (!pstate_reg.pstate_en) |