summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-12 21:25:16 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-14 08:34:51 +0000
commit8e6146049fa50ea089437bb63b9f8e387cd975f2 (patch)
tree1f34bb79bb8be37eb1cb5e08b90420d21c866be4 /src
parentc77b607138cba25e6fc979c176a8c6b255687a59 (diff)
intel/i82371eb,speedstep: Use dev_count_cpu()
Change-Id: I8582d401c72ad44137f117315c5c6869654c3e99 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74397 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src')
-rw-r--r--src/cpu/intel/speedstep/acpi.c14
-rw-r--r--src/southbridge/intel/i82371eb/acpi_tables.c14
2 files changed, 2 insertions, 26 deletions
diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c
index 839fec4185..acca77edf9 100644
--- a/src/cpu/intel/speedstep/acpi.c
+++ b/src/cpu/intel/speedstep/acpi.c
@@ -9,18 +9,6 @@
#include <device/device.h>
#include <types.h>
-static int determine_total_number_of_cores(void)
-{
- struct device *cpu;
- int count = 0;
- for (cpu = all_devices; cpu; cpu = cpu->next) {
- if (!is_enabled_cpu(cpu))
- continue;
- count++;
- }
- return count;
-}
-
static void gen_pstate_entries(const sst_table_t *const pstates,
const int cpuID, const int cores_per_package,
const uint8_t coordination)
@@ -78,7 +66,7 @@ static void gen_pstate_entries(const sst_table_t *const pstates,
void generate_cpu_entries(const struct device *device)
{
int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;
- int totalcores = determine_total_number_of_cores();
+ int totalcores = dev_count_cpu();
int cores_per_package = (cpuid_ebx(1)>>16) & 0xff;
int numcpus = totalcores/cores_per_package; /* This assumes that all
CPUs share the same
diff --git a/src/southbridge/intel/i82371eb/acpi_tables.c b/src/southbridge/intel/i82371eb/acpi_tables.c
index c23c2f6f31..cd002e8135 100644
--- a/src/southbridge/intel/i82371eb/acpi_tables.c
+++ b/src/southbridge/intel/i82371eb/acpi_tables.c
@@ -6,22 +6,10 @@
#include <device/device.h>
#include "i82371eb.h"
-static int determine_total_number_of_cores(void)
-{
- struct device *cpu;
- int count = 0;
- for (cpu = all_devices; cpu; cpu = cpu->next) {
- if (!is_enabled_cpu(cpu))
- continue;
- count++;
- }
- return count;
-}
-
void generate_cpu_entries(const struct device *device)
{
int cpu, pcontrol_blk=DEFAULT_PMBASE+PCNTRL, plen=6;
- int numcpus = determine_total_number_of_cores();
+ int numcpus = dev_count_cpu();
printk(BIOS_DEBUG, "Found %d CPU(s).\n", numcpus);
/* without the outer scope, further ssdt addition will end up