summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJason Glenesk <jason.glenesk@amd.corp-partner.google.com>2020-07-31 10:04:56 -0700
committerFelix Held <felix-coreboot@felixheld.de>2020-08-05 20:10:53 +0000
commit1e8ef3c45869b61589e967d679d10df966be90f4 (patch)
tree9fd5e1fd4b6faaf124f8996d0d24b7b3bba2fb62 /src
parent01707406a15be603afb86d9a26331205b48b564c (diff)
vendorcode/amd/fsp/picasso Fix type 17 smbios misalignment
Add __packed to TYPE17_DMI_INFO structure to remove padding. Remove reserved fields that are no longer required. Corresponding change will also be made within fsp to pack the structure. BUG=b:154046847 TEST=Boot a trembyle with and without the reserved fields and confirm type 17 table is unchanged. Cq-Depend: chrome-internal:3194239 Change-Id: I9ba7e2a4fb82c7b0b77ee7c6c075e6211d4f6adf Signed-off-by: Jason Glenesk <jason.glenesk@amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44086 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Rob Barnes <robbarnes@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/vendorcode/amd/fsp/picasso/dmi_info.h4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/vendorcode/amd/fsp/picasso/dmi_info.h b/src/vendorcode/amd/fsp/picasso/dmi_info.h
index adab2f92a3..36ca7195ba 100644
--- a/src/vendorcode/amd/fsp/picasso/dmi_info.h
+++ b/src/vendorcode/amd/fsp/picasso/dmi_info.h
@@ -178,7 +178,6 @@ typedef struct {
OUT DMI_T17_MEMORY_TYPE MemoryType; ///< The type of memory used in this device.
OUT DMI_T17_TYPE_DETAIL TypeDetail; ///< Additional detail on the memory device type
OUT UINT16 Speed; ///< Identifies the speed of the device, in megahertz (MHz).
- OUT UINT32 _Reserved1_;
OUT UINT64 ManufacturerIdCode; ///< Manufacturer ID code.
OUT CHAR8 SerialNumber[9]; ///< Serial Number.
OUT CHAR8 PartNumber[21]; ///< Part Number.
@@ -188,8 +187,7 @@ typedef struct {
OUT UINT16 MinimumVoltage; ///< Minimum operating voltage for this device, in millivolts
OUT UINT16 MaximumVoltage; ///< Maximum operating voltage for this device, in millivolts
OUT UINT16 ConfiguredVoltage; ///< Configured voltage for this device, in millivolts
- OUT UINT32 _Reserved2_;
-} TYPE17_DMI_INFO;
+}__packed TYPE17_DMI_INFO;
/// Collection of pointers to the DMI records
typedef struct {