summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-10-27 07:18:41 +0100
committerArthur Heymans <arthur@aheymans.xyz>2019-11-10 15:39:00 +0000
commit1c54bc4849a4ab6b78612b47ca0727bd16e8cf92 (patch)
treee1eaeafb677d7b4c44a35cd6e5e95d5659664712 /src
parent8b7cd43d5d5af1d192b0bbe34e6aff776df90a0f (diff)
lib/cbmem: Remove the cbmem_top_init() hook
This hook is unused and with the need for initializing storage to share cbmem_top over other stages gone, there is likely no future need for this. Change-Id: I4ba9daea61b6d7b8949bbd2c4fb71d0a0fa20d93 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36369 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Michael Niewöhner Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src')
-rw-r--r--src/include/cbmem.h5
-rw-r--r--src/lib/imd_cbmem.c6
2 files changed, 0 insertions, 11 deletions
diff --git a/src/include/cbmem.h b/src/include/cbmem.h
index a22c420ad3..cf79f41a71 100644
--- a/src/include/cbmem.h
+++ b/src/include/cbmem.h
@@ -63,11 +63,6 @@ int cbmem_initialize_id_size(u32 id, u64 size);
void cbmem_initialize_empty(void);
void cbmem_initialize_empty_id_size(u32 id, u64 size);
-/* Optional hook for platforms to initialize cbmem_top() value. When employed
- * it's called a single time during boot at cbmem initialization/recovery
- * time. */
-void cbmem_top_init(void);
-
/* Return the top address for dynamic cbmem. The address returned needs to
* be consistent across romstage and ramstage, and it is required to be
* below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no
diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c
index 38620d2d06..6eb3e6096c 100644
--- a/src/lib/imd_cbmem.c
+++ b/src/lib/imd_cbmem.c
@@ -130,10 +130,6 @@ void cbmem_initialize_empty(void)
cbmem_initialize_empty_id_size(0, 0);
}
-void __weak cbmem_top_init(void)
-{
-}
-
static void cbmem_top_init_once(void)
{
/* Call one-time hook on expected cbmem init during boot. This sequence
@@ -141,8 +137,6 @@ static void cbmem_top_init_once(void)
if (!ENV_ROMSTAGE)
return;
- cbmem_top_init();
-
/* The test is only effective on X86 and when address hits UC memory. */
if (ENV_X86)
quick_ram_check_or_die((uintptr_t)cbmem_top() - sizeof(u32));