diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/vendorcode/eltan | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/vendorcode/eltan')
| -rw-r--r-- | src/vendorcode/eltan/security/verified_boot/vboot_check.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/vendorcode/eltan/security/verified_boot/vboot_check.c b/src/vendorcode/eltan/security/verified_boot/vboot_check.c index ed20af5076..09da5c50ad 100644 --- a/src/vendorcode/eltan/security/verified_boot/vboot_check.c +++ b/src/vendorcode/eltan/security/verified_boot/vboot_check.c @@ -36,13 +36,13 @@ int verified_boot_check_manifest(void) buffer = cbfs_map(RSA_PUBLICKEY_FILE_NAME, &size); if (!buffer || !size) { - printk(BIOS_ERR, "ERROR: Public key not found!\n"); + printk(BIOS_ERR, "Public key not found!\n"); goto fail; } if ((size != CONFIG_VENDORCODE_ELTAN_VBOOT_KEY_SIZE) || (buffer != (void *)CONFIG_VENDORCODE_ELTAN_VBOOT_KEY_LOCATION)) { - printk(BIOS_ERR, "ERROR: Illegal public key!\n"); + printk(BIOS_ERR, "Illegal public key!\n"); goto fail; } @@ -53,7 +53,7 @@ int verified_boot_check_manifest(void) if ((sd->workbuf_used + size + sizeof(struct vb2_kernel_preamble) + ((CONFIG_VENDORCODE_ELTAN_OEM_MANIFEST_ITEMS * DIGEST_SIZE) + (2048/8))) > sizeof(wb_buffer)) { - printk(BIOS_ERR, "ERROR: Work buffer too small\n"); + printk(BIOS_ERR, "Work buffer too small\n"); goto fail; } @@ -74,7 +74,7 @@ int verified_boot_check_manifest(void) /* Fill body_signature (vb2_structure). RSA2048 key is used */ cbfs_map("oemmanifest.bin", &size); if (size != ((CONFIG_VENDORCODE_ELTAN_OEM_MANIFEST_ITEMS * DIGEST_SIZE) + (2048/8))) { - printk(BIOS_ERR, "ERROR: Incorrect manifest size!\n"); + printk(BIOS_ERR, "Incorrect manifest size!\n"); goto fail; } pre->body_signature.data_size = CONFIG_VENDORCODE_ELTAN_OEM_MANIFEST_ITEMS * |