diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-04-03 14:40:24 +1100 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-06 06:23:08 +0200 |
| commit | 4f5a5254c5ad0aa0227113c3fd31b12c0783c131 (patch) | |
| tree | ade0bfb5585092415dedd2e110f8cee446985ced /src/superio | |
| parent | 5ff4b086ba1c1ff1e82ef5b7db1e776aeff3fcb7 (diff) | |
superio/winbond/w83627thg: Avoid .c includes
Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage
code.
Change-Id: I1f7c20ac7841874125b6bfcd9f9db25d96355881
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5449
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src/superio')
| -rw-r--r-- | src/superio/winbond/w83627thg/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/superio/winbond/w83627thg/chip.h | 2 | ||||
| -rw-r--r-- | src/superio/winbond/w83627thg/early_serial.c | 7 | ||||
| -rw-r--r-- | src/superio/winbond/w83627thg/w83627thg.h | 6 |
4 files changed, 11 insertions, 6 deletions
diff --git a/src/superio/winbond/w83627thg/Makefile.inc b/src/superio/winbond/w83627thg/Makefile.inc index 8a03c8fa59..20a2ad0e60 100644 --- a/src/superio/winbond/w83627thg/Makefile.inc +++ b/src/superio/winbond/w83627thg/Makefile.inc @@ -20,5 +20,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_WINBOND_W83627THG) += early_serial.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83627THG) += superio.c - diff --git a/src/superio/winbond/w83627thg/chip.h b/src/superio/winbond/w83627thg/chip.h index 692715e2c2..1677b97fec 100644 --- a/src/superio/winbond/w83627thg/chip.h +++ b/src/superio/winbond/w83627thg/chip.h @@ -30,4 +30,4 @@ struct superio_winbond_w83627thg_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_WINBOND_W83627THG_CHIP_H */ diff --git a/src/superio/winbond/w83627thg/early_serial.c b/src/superio/winbond/w83627thg/early_serial.c index 8ba1a308ae..cc84738e49 100644 --- a/src/superio/winbond/w83627thg/early_serial.c +++ b/src/superio/winbond/w83627thg/early_serial.c @@ -21,22 +21,23 @@ */ #include <arch/io.h> +#include <device/pnp.h> #include "w83627thg.h" -static void pnp_enter_ext_func_mode(device_t dev) +void pnp_enter_ext_func_mode(device_t dev) { u16 port = dev >> 8; outb(0x87, port); outb(0x87, port); } -static void pnp_exit_ext_func_mode(device_t dev) +void pnp_exit_ext_func_mode(device_t dev) { u16 port = dev >> 8; outb(0xaa, port); } -static void inline w83627thg_enable_serial(device_t dev, u16 iobase) +void w83627thg_enable_serial(device_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/winbond/w83627thg/w83627thg.h b/src/superio/winbond/w83627thg/w83627thg.h index 8077de463b..a5cc450052 100644 --- a/src/superio/winbond/w83627thg/w83627thg.h +++ b/src/superio/winbond/w83627thg/w83627thg.h @@ -34,6 +34,10 @@ #define W83627THG_ACPI 10 #define W83627THG_HWM 11 /* Hardware monitor */ +void pnp_enter_ext_func_mode(device_t dev); +void pnp_exit_ext_func_mode(device_t dev); + void w83627thg_set_clksel_48(device_t dev); +void w83627thg_enable_serial(device_t dev, u16 iobase); -#endif +#endif /* SUPERIO_WINBOND_W83627THG_W83627THG_H */ |