summaryrefslogtreecommitdiff
path: root/src/superio
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-10-17 14:57:39 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-10-19 07:05:42 +0000
commit9357ac38606a2b928692a1251b7c9f4aef289334 (patch)
tree327ba9480794bcaf78d2321b20c3686a83fccfc9 /src/superio
parente16971ac64dc36375e5d606cd51950f2807c5bdb (diff)
superio/nuvoton: Correct NCT6791D COM A mux toggle
Bit 6 of global CR 0x2a toggles the mux for COM B. Bit 7 works just like on the other two Nuvoton Super I/Os, so fold the conditionals together. Change-Id: I8cebe35587ae68cac93ed392342662678621efd6 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46521 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Diffstat (limited to 'src/superio')
-rw-r--r--src/superio/nuvoton/common/early_serial.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c
index ed5fdbab1f..398678983a 100644
--- a/src/superio/nuvoton/common/early_serial.c
+++ b/src/superio/nuvoton/common/early_serial.c
@@ -53,14 +53,11 @@ void nuvoton_enable_serial(pnp_devfn_t dev, u16 iobase)
nuvoton_pnp_enter_conf_state(dev);
if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A) ||
+ CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A) ||
CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A))
/* Route COM A to GPIO8 pin group */
pnp_unset_and_set_config(dev, 0x2a, 1 << 7, 0);
- if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A))
- /* Route COM A to GPIO8 pin group */
- pnp_write_config(dev, 0x2a, 0x00);
-
pnp_set_logical_device(dev);
pnp_set_enable(dev, 0);
pnp_set_iobase(dev, PNP_IDX_IO0, iobase);