diff options
author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
---|---|---|
committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/superio/winbond | |
parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/superio/winbond')
-rw-r--r-- | src/superio/winbond/w83627dhg/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83627ehg/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83627hf/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83627thg/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83627uhg/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83667hg-a/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83977tf/superio.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/wpcd376i/superio.c | 2 |
8 files changed, 8 insertions, 8 deletions
diff --git a/src/superio/winbond/w83627dhg/superio.c b/src/superio/winbond/w83627dhg/superio.c index 2641cb324b..491b5c9c6d 100644 --- a/src/superio/winbond/w83627dhg/superio.c +++ b/src/superio/winbond/w83627dhg/superio.c @@ -68,6 +68,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83627dhg_ops = { - CHIP_NAME("Winbond W83627DHG Super I/O") + .name = "Winbond W83627DHG Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index 1e36048146..03dce827cb 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -129,6 +129,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83627ehg_ops = { - CHIP_NAME("Winbond W83627EHG Super I/O") + .name = "Winbond W83627EHG Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c index de2a0c6491..f0c5b2870d 100644 --- a/src/superio/winbond/w83627hf/superio.c +++ b/src/superio/winbond/w83627hf/superio.c @@ -129,6 +129,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83627hf_ops = { - CHIP_NAME("Winbond W83627HF Super I/O") + .name = "Winbond W83627HF Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83627thg/superio.c b/src/superio/winbond/w83627thg/superio.c index 4276da6f5b..156239f1a3 100644 --- a/src/superio/winbond/w83627thg/superio.c +++ b/src/superio/winbond/w83627thg/superio.c @@ -50,6 +50,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83627thg_ops = { - CHIP_NAME("Winbond W83627THG Super I/O") + .name = "Winbond W83627THG Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c index 4b54bac98d..e276fc5e08 100644 --- a/src/superio/winbond/w83627uhg/superio.c +++ b/src/superio/winbond/w83627uhg/superio.c @@ -101,6 +101,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83627uhg_ops = { - CHIP_NAME("Winbond W83627UHG Super I/O") + .name = "Winbond W83627UHG Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83667hg-a/superio.c b/src/superio/winbond/w83667hg-a/superio.c index a5abe61818..4cddf20187 100644 --- a/src/superio/winbond/w83667hg-a/superio.c +++ b/src/superio/winbond/w83667hg-a/superio.c @@ -103,6 +103,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83667hg_a_ops = { - CHIP_NAME("WINBOND W83667HG-A Super I/O") + .name = "WINBOND W83667HG-A Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/w83977tf/superio.c b/src/superio/winbond/w83977tf/superio.c index 4187b52a42..28bfc8c4cd 100644 --- a/src/superio/winbond/w83977tf/superio.c +++ b/src/superio/winbond/w83977tf/superio.c @@ -50,6 +50,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_w83977tf_ops = { - CHIP_NAME("Winbond W83977TF Super I/O") + .name = "Winbond W83977TF Super I/O", .enable_dev = enable_dev, }; diff --git a/src/superio/winbond/wpcd376i/superio.c b/src/superio/winbond/wpcd376i/superio.c index a692eeb25d..635d02512b 100644 --- a/src/superio/winbond/wpcd376i/superio.c +++ b/src/superio/winbond/wpcd376i/superio.c @@ -61,6 +61,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_winbond_wpcd376i_ops = { - CHIP_NAME("Winbond WPCD376I Super I/O") + .name = "Winbond WPCD376I Super I/O", .enable_dev = enable_dev, }; |