summaryrefslogtreecommitdiff
path: root/src/superio/winbond
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2020-08-26 18:36:13 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-11 22:19:38 +0000
commit9b54dfa1d0e3b67ee88db5dddc2f087e396179d1 (patch)
treef1bfad1696a022548c7af724b05d30041a2e6f11 /src/superio/winbond
parentaa03f30e6ecd999cff5b0ad0f166d2ed7471b62b (diff)
src/superio: Use 'PNP_IDX_*' macros instead of magic numbers
Change-Id: I2f8d6d9e8b6e84bb6c2b4e73b0fbeca476130d05 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44833 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/superio/winbond')
-rw-r--r--src/superio/winbond/w83627uhg/superio.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c
index 588cda4fb3..00bea8cf03 100644
--- a/src/superio/winbond/w83627uhg/superio.c
+++ b/src/superio/winbond/w83627uhg/superio.c
@@ -2,6 +2,7 @@
#include <device/device.h>
#include <device/pnp.h>
+#include <device/pnp_def.h>
#include <superio/conf_mode.h>
#include <stdint.h>
#include <pc80/keyboard.h>
@@ -29,10 +30,10 @@ static void set_uart_clock_source(struct device *dev, u8 uart_clock)
pnp_enter_conf_mode(dev);
pnp_set_logical_device(dev);
- value = pnp_read_config(dev, 0xf0);
+ value = pnp_read_config(dev, PNP_IDX_MSC0);
value &= ~0x03;
value |= (uart_clock & 0x03);
- pnp_write_config(dev, 0xf0, value);
+ pnp_write_config(dev, PNP_IDX_MSC0, value);
pnp_exit_conf_mode(dev);
}