diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-10 14:53:36 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-10 14:53:36 +0000 |
| commit | 340fa9396b4b73fd894a15fe48882c98d74292ce (patch) | |
| tree | fd38d38490431ddb2c210ffbc39b4771ce08eda2 /src/superio/winbond/w83627hf/w83627hf.h | |
| parent | 02d66fd1bf3e5548dc5edaed074d2946fe5a37df (diff) | |
Random Winbond Super I/O cosmetic and coding-style fixes.
- Whitespace, coding style, and typo fixes.
- Drop unused/obsolete "#config chip.h".
- Use u8/u16/etc. everywhere.
- Use pnp_read_config()/pnp_write_config() instead of open-coding them.
- Use pnp_set_logical_device() instead of open-coding it.
- W83627EHG: Fix incorrect enable_hwm_smbus() code comment.
- Use ARRAY_SIZE.
- w83627hf/superio.c: w83627hf_16_bit_addr_qual(): Bugfix, the code was using
'dev->path.pnp.port >> 8' as config port, which is incorrect in superio.c
(which has a "real" device_t struct, in contrast to *_early_serial.c which
uses "unsigned" as device_t where 'dev >> 8' is required).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6057 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/winbond/w83627hf/w83627hf.h')
| -rw-r--r-- | src/superio/winbond/w83627hf/w83627hf.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/superio/winbond/w83627hf/w83627hf.h b/src/superio/winbond/w83627hf/w83627hf.h index cb186a90f6..f0566fc30f 100644 --- a/src/superio/winbond/w83627hf/w83627hf.h +++ b/src/superio/winbond/w83627hf/w83627hf.h @@ -3,7 +3,7 @@ * * Copyright (C) 2000 AG Electronics Ltd. * Copyright (C) 2003-2004 Linux Networx - * Copyright (C) 2004 Tyan By LYH change from PC87360 + * Copyright (C) 2004 Tyan * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -24,16 +24,16 @@ #define SUPERIO_WINBOND_W83627HF_W83627HF_H #define W83627HF_FDC 0 /* Floppy */ -#define W83627HF_PP 1 /* Parallel Port */ +#define W83627HF_PP 1 /* Parallel port */ #define W83627HF_SP1 2 /* Com1 */ #define W83627HF_SP2 3 /* Com2 */ -#define W83627HF_KBC 5 /* Keyboard & Mouse */ +#define W83627HF_KBC 5 /* PS/2 keyboard & mouse */ #define W83627HF_CIR 6 #define W83627HF_GAME_MIDI_GPIO1 7 #define W83627HF_GPIO2 8 #define W83627HF_GPIO3 9 #define W83627HF_ACPI 10 -#define W83627HF_HWM 11 /* Hardware Monitor */ +#define W83627HF_HWM 11 /* Hardware monitor */ /* #define W83627HF_GPIO_DEV PNP_DEV(0x2e, W83627HF_GPIO) */ /* #define W83627HF_XBUS_DEV PNP_DEV(0x2e, W83627HF_XBUS) */ @@ -115,8 +115,8 @@ #if defined(__PRE_RAM__) && !defined(__ROMCC__) void w83627hf_disable_dev(device_t dev); -void w83627hf_enable_dev(device_t dev, unsigned iobase); -void w83627hf_enable_serial(device_t dev, unsigned iobase); +void w83627hf_enable_dev(device_t dev, u16 iobase); +void w83627hf_enable_serial(device_t dev, u16 iobase); void w83627hf_set_clksel_48(device_t dev); #endif |