summaryrefslogtreecommitdiff
path: root/src/superio/smsc
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2015-01-04 16:28:37 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2015-01-04 13:48:47 +0100
commit520a328e5a6c0185b6735ff68c0e166ba9a4d36d (patch)
tree7fc8c321fd280d7b13db386f461f86aac827f887 /src/superio/smsc
parent117849ef4d02fe3888fac1742511ca812cac811b (diff)
src/superio/smsc/lpc47m10x/superio.c: Remove dead code
Remove dead debug code, we have superiotool for this reason. Restructure file to be consistent with other superio's thereby avoiding forward declarations of functions. Change-Id: Ief60d3f54c508cbb7795b284b59710d2c0e3018b Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/8082 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/superio/smsc')
-rw-r--r--src/superio/smsc/lpc47m10x/superio.c90
1 files changed, 22 insertions, 68 deletions
diff --git a/src/superio/smsc/lpc47m10x/superio.c b/src/superio/smsc/lpc47m10x/superio.c
index 8530056f83..4cd9a8b961 100644
--- a/src/superio/smsc/lpc47m10x/superio.c
+++ b/src/superio/smsc/lpc47m10x/superio.c
@@ -33,15 +33,25 @@
#include <stdlib.h>
#include "lpc47m10x.h"
-/* Forward declarations */
-static void enable_dev(struct device *dev);
-static void lpc47m10x_init(struct device *dev);
-// static void dump_pnp_device(struct device *dev);
+/**
+ * Initialize the specified Super I/O device.
+ *
+ * Devices other than COM ports and the keyboard controller are ignored.
+ * For COM ports, we configure the baud rate.
+ *
+ * @param dev Pointer to structure describing a Super I/O device.
+ */
+static void lpc47m10x_init(struct device *dev)
+{
+ if (!dev->enabled)
+ return;
-struct chip_operations superio_smsc_lpc47m10x_ops = {
- CHIP_NAME("SMSC LPC47M10x Super I/O")
- .enable_dev = enable_dev
-};
+ switch(dev->path.pnp.device) {
+ case LPC47M10X2_KBC:
+ pc_keyboard_init();
+ break;
+ }
+}
static struct device_operations ops = {
.read_resources = pnp_read_resources,
@@ -73,63 +83,7 @@ static void enable_dev(struct device *dev)
pnp_dev_info);
}
-/**
- * Initialize the specified Super I/O device.
- *
- * Devices other than COM ports and the keyboard controller are ignored.
- * For COM ports, we configure the baud rate.
- *
- * @param dev Pointer to structure describing a Super I/O device.
- */
-static void lpc47m10x_init(struct device *dev)
-{
-
- if (!dev->enabled)
- return;
-
- switch(dev->path.pnp.device) {
- case LPC47M10X2_KBC:
- pc_keyboard_init();
- break;
- }
-}
-
-#if 0
-/**
- * Print the values of all of the LPC47M10X2's configuration registers.
- *
- * NOTE: The LPC47M10X2 must be in config mode when this function is called.
- *
- * @param dev Pointer to structure describing a Super I/O device.
- */
-static void dump_pnp_device(struct device *dev)
-{
- int i;
- print_debug("\n");
-
- for (i = 0; i <= LPC47M10X2_MAX_CONFIG_REGISTER; i++) {
- u8 register_value;
-
- if ((i & 0x0f) == 0) {
- print_debug_hex8(i);
- print_debug_char(':');
- }
-
- /*
- * Skip over 'register' that would cause exit from
- * configuration mode.
- */
- if (i == 0xaa)
- register_value = 0xaa;
- else
- register_value = pnp_read_config(dev, i);
-
- print_debug_char(' ');
- print_debug_hex8(register_value);
- if ((i & 0x0f) == 0x0f)
- print_debug("\n");
- }
-
- print_debug("\n");
-}
-#endif
+struct chip_operations superio_smsc_lpc47m10x_ops = {
+ CHIP_NAME("SMSC LPC47M10x Super I/O")
+ .enable_dev = enable_dev
+};