diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
commit | a69d978be8a068944466e776de87527fb104a878 (patch) | |
tree | 8acf4247e3104ad9ccb940568a81e472105a674b /src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c | |
parent | 2e9323e5bef293c051d9fd982214e6db2e3305ee (diff) |
C and other Super I/O cosmetic fixes.
- Random coding style, whitespace and cosmetic fixes.
- Consistently use the same spacing and 4-hexdigit port number format
in the pnp_dev_info[] arrays.
- Drop dead/unused code and less useful comments.
- Add missing "(C)" characters and copyright years.
- Shorten and simplify some code snippets.
- Use u8/u16/etc. everywhere.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6073 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c')
-rw-r--r-- | src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c b/src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c index 8eff2325ba..16066b75cd 100644 --- a/src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c +++ b/src/superio/smsc/lpc47b397/lpc47b397_early_gpio.c @@ -20,30 +20,30 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -static void lpc47b397_gpio_offset_out(unsigned iobase, unsigned offset, unsigned value) +static void lpc47b397_gpio_offset_out(u16 iobase, u16 offset, u8 value) { - outb(value,iobase+offset); + outb(value, iobase + offset); } -static unsigned lpc47b397_gpio_offset_in(unsigned iobase, unsigned offset) +static u8 lpc47b397_gpio_offset_in(u16 iobase, u16 offset) { return inb(iobase+offset); } #if 0 -/* for GP60-GP64, GP66-GP85 */ +/* For GP60-GP64, GP66-GP85. */ #define LPC47B397_GPIO_CNTL_INDEX 0x70 #define LPC47B397_GPIO_CNTL_DATA 0x71 -static void lpc47b397_gpio_index_out(unsigned iobase, unsigned index, unsigned value) +static void lpc47b397_gpio_index_out(u16 iobase, u8 index, u8 value) { - outb(index,iobase+LPC47B397_GPIO_CNTL_INDEX); - outb(value, iobase+LPC47B397_GPIO_CNTL_DATA); + outb(index, iobase + LPC47B397_GPIO_CNTL_INDEX); + outb(value, iobase + LPC47B397_GPIO_CNTL_DATA); } -static unsigned lpc47b397_gpio_index_in(unsigned iobase, unsigned index) +static u8 lpc47b397_gpio_index_in(u16 iobase, u8 index) { - outb(index,iobase+LPC47B397_GPIO_CNTL_INDEX); - return inb(iobase+LPC47B397_GPIO_CNTL_DATA); + outb(index, iobase + LPC47B397_GPIO_CNTL_INDEX); + return inb(iobase + LPC47B397_GPIO_CNTL_DATA); } #endif |