diff options
| author | Nico Huber <nico.h@gmx.de> | 2013-06-10 22:57:12 +0200 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-06-17 21:38:37 +0200 |
| commit | f898f7ba4d10146b45241afe65fd54b3c049cc4f (patch) | |
| tree | d0aa5c8874521f998f794c12fce9b5dfc80abeed /src/superio/ite | |
| parent | a00f9830fb58d3f5061aab71be8553f3ff2e1f70 (diff) | |
pnp: Provide alternative pnp_enable() implementation
The current default implementation of pnp_enable() only disables devices
- if set so in the devicetree - but does not enable them. Enablement takes
place in pnp_enable_resources(). Yet, many PnP chips implement their own
version of pnp_enable() which also enables devices if set in the devicetree.
It's arguable, if enabling those devices makes sense, before they get
resources assigned. Maybe we can't write the resource registers if not,
who knows? The least we can do is providing a common implementation for
this behavior, and get rid of some code duplication.
Used the following cocci:
@@
expression e;
@@
+pnp_alt_enable(e);
-pnp_set_logical_device(e);
(
-pnp_set_enable(e, !!e->enabled);
|
-(e->enabled) ? pnp_set_enable(e, 1) : pnp_set_enable(e, 0);
|
-if (e->enabled) { pnp_set_enable(e, 1); }
-else { pnp_set_enable(e, 0); }
)
Change-Id: I8d695e8fcd3cf8b847b1aa99326b51a554700bc4
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: http://review.coreboot.org/3480
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/superio/ite')
| -rw-r--r-- | src/superio/ite/it8712f/superio.c | 3 | ||||
| -rw-r--r-- | src/superio/ite/it8716f/superio.c | 3 | ||||
| -rw-r--r-- | src/superio/ite/it8772f/superio.c | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/src/superio/ite/it8712f/superio.c b/src/superio/ite/it8712f/superio.c index bf649dac7a..66b0aecdf0 100644 --- a/src/superio/ite/it8712f/superio.c +++ b/src/superio/ite/it8712f/superio.c @@ -89,8 +89,7 @@ static void it8712f_pnp_enable_resources(device_t dev) static void it8712f_pnp_enable(device_t dev) { pnp_enter_ext_func_mode(dev); - pnp_set_logical_device(dev); - pnp_set_enable(dev, !!dev->enabled); + pnp_alt_enable(dev); pnp_exit_ext_func_mode(dev); } diff --git a/src/superio/ite/it8716f/superio.c b/src/superio/ite/it8716f/superio.c index 98b673214d..f021a0b7d8 100644 --- a/src/superio/ite/it8716f/superio.c +++ b/src/superio/ite/it8716f/superio.c @@ -113,8 +113,7 @@ static void it8716f_pnp_enable_resources(device_t dev) static void it8716f_pnp_enable(device_t dev) { pnp_enter_ext_func_mode(dev); - pnp_set_logical_device(dev); - pnp_set_enable(dev, !!dev->enabled); + pnp_alt_enable(dev); pnp_exit_ext_func_mode(dev); } diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c index b6c4405d9b..de1c17908a 100644 --- a/src/superio/ite/it8772f/superio.c +++ b/src/superio/ite/it8772f/superio.c @@ -205,8 +205,7 @@ static void it8772f_pnp_enable_resources(device_t dev) static void it8772f_pnp_enable(device_t dev) { pnp_enter_ext_func_mode(dev); - pnp_set_logical_device(dev); - pnp_set_enable(dev, !!dev->enabled); + pnp_alt_enable(dev); pnp_exit_ext_func_mode(dev); } |