diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-08 15:16:30 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-08 15:16:30 +0000 |
| commit | 5c6bae213ea55e1436e010706560d86120b0b286 (patch) | |
| tree | 48373faf8bc3a9e0628eeb1002508402c5b9299e /src/superio/ite/it8716f/it8716f.h | |
| parent | 6018e1ba7f797db3a7f1ae34bdb10ec1fa5c8a6c (diff) | |
Random ITE Super I/O fixes.
- Drop some of the less useful / outdated / duplicated comments.
- Simplify and streamline some code to look like the other Super I/Os.
- Use u8/16/etc. everywhere.
- ITE IT8718F: Add missing GPIO LDN.
- Add missing braces around SIO_DATA #defines, potential bug even.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6047 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/ite/it8716f/it8716f.h')
| -rw-r--r-- | src/superio/ite/it8716f/it8716f.h | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/superio/ite/it8716f/it8716f.h b/src/superio/ite/it8716f/it8716f.h index 2d72a17554..88e44c219d 100644 --- a/src/superio/ite/it8716f/it8716f.h +++ b/src/superio/ite/it8716f/it8716f.h @@ -19,7 +19,6 @@ */ /* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8716_2.asp */ -/* Status: Untested on real hardware, but it compiles. */ #ifndef SUPERIO_ITE_IT8716F_IT8716F_H #define SUPERIO_ITE_IT8716F_IT8716F_H @@ -29,22 +28,22 @@ #define IT8716F_SP2 0x02 /* Com2 */ #define IT8716F_PP 0x03 /* Parallel port */ #define IT8716F_EC 0x04 /* Environment controller */ -#define IT8716F_KBCK 0x05 /* Keyboard */ -#define IT8716F_KBCM 0x06 /* Mouse */ +#define IT8716F_KBCK 0x05 /* PS/2 keyboard */ +#define IT8716F_KBCM 0x06 /* PS/2 mouse */ #define IT8716F_GPIO 0x07 /* GPIO */ #define IT8716F_MIDI 0x08 /* MIDI port */ #define IT8716F_GAME 0x09 /* GAME port */ #define IT8716F_IR 0x0a /* Consumer IR */ #if defined(CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL) && CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL -/* provided by mainboard, called by it8716f superio.c */ -void init_ec(uint16_t base); +/* Provided by mainboard, called by IT8716F superio.c. */ +void init_ec(u16 base); #endif #if defined(__PRE_RAM__) && !defined(__ROMCC__) void it8716f_disable_dev(device_t dev); -void it8716f_enable_dev(device_t dev, unsigned iobase); -void it8716f_enable_serial(device_t dev, unsigned iobase); +void it8716f_enable_dev(device_t dev, u16 iobase); +void it8716f_enable_serial(device_t dev, u16 iobase); #endif #endif |