diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-03-29 20:28:03 +1100 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-03-31 01:05:40 +0200 |
| commit | d3043313a91dff3bc2f879ffb3b4bf23a364d711 (patch) | |
| tree | 04d7332c24c28c87ce2f44c190af9a6ed1c957f8 /src/superio/fintek | |
| parent | 01c44000bedc571b10bdae7d0acfba079a131e42 (diff) | |
superio/fintek/f81865f: Avoid .c includes
We should not be #include .c files, instead link early_serial into
romstage and provide a prototype.
Change-Id: Ia9277169ce1592e1fc72f8849f0982741daec567
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5416
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/superio/fintek')
| -rw-r--r-- | src/superio/fintek/f81865f/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/superio/fintek/f81865f/chip.h | 2 | ||||
| -rw-r--r-- | src/superio/fintek/f81865f/early_serial.c (renamed from src/superio/fintek/f81865f/f81865f_early_serial.c) | 3 | ||||
| -rw-r--r-- | src/superio/fintek/f81865f/f81865f.h | 4 |
4 files changed, 7 insertions, 3 deletions
diff --git a/src/superio/fintek/f81865f/Makefile.inc b/src/superio/fintek/f81865f/Makefile.inc index 1700f7c272..8afb2860ca 100644 --- a/src/superio/fintek/f81865f/Makefile.inc +++ b/src/superio/fintek/f81865f/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F81865F) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F81865F) += superio.c diff --git a/src/superio/fintek/f81865f/chip.h b/src/superio/fintek/f81865f/chip.h index fc17c0f72f..ae4da18cc4 100644 --- a/src/superio/fintek/f81865f/chip.h +++ b/src/superio/fintek/f81865f/chip.h @@ -30,4 +30,4 @@ struct superio_fintek_f81865f_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F81865_CHIP_H */ diff --git a/src/superio/fintek/f81865f/f81865f_early_serial.c b/src/superio/fintek/f81865f/early_serial.c index 2989b5f911..29b5f9d658 100644 --- a/src/superio/fintek/f81865f/f81865f_early_serial.c +++ b/src/superio/fintek/f81865f/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F81865F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f81865f.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f81865f_enable_serial(device_t dev, u16 iobase) +void f81865f_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f81865f/f81865f.h b/src/superio/fintek/f81865f/f81865f.h index 0c36571867..ccf41af4aa 100644 --- a/src/superio/fintek/f81865f/f81865f.h +++ b/src/superio/fintek/f81865f/f81865f.h @@ -35,4 +35,6 @@ #define F81865F_GPIO 0x06 /* General Purpose I/O (GPIO) */ #define F81865F_PME 0x0a /* Power Management Events (PME) */ -#endif +void f81865f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F81865_F81865_H */ |