diff options
author | Mark Marshall <mark.marshall@csr.com> | 2009-11-05 09:03:04 +0000 |
---|---|---|
committer | Stefan Reinauer <stepan@openbios.org> | 2009-11-05 09:03:04 +0000 |
commit | d08e69dd5e8fdddcef10b31dea223a9b2fd70d94 (patch) | |
tree | 105d363c043c5c5250c0e11a3a4f43dd0b6e7a14 /src/superio/fintek/Makefile.inc | |
parent | 2fa7c2e210dc685d091c8bbb4012c91b80fc0a81 (diff) |
Use more care when implementing the PCI BIOS functions.
The READ_CONF and WRITE_CONF functions would both do the wrong thing
if the passed in BDF was not found. We should return and error to the
caller, but not stop running the option ROM.
Signed-off-by: Mark Marshall <mark.marshall@csr.com>
I slightly reworked the patch:
The 'CHECK' function seemed to be both wrong code and the wrong
number.
In fact the CHECK function was given the function number of
the "Microsoft Real-Time Compression Interface". Since this is definitely wrong
I removed the code.
Dropped some unneeded scopes, too, to make the code easier to read.
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4910 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/fintek/Makefile.inc')
0 files changed, 0 insertions, 0 deletions