sb,soc/amd: Drop OSFL method in ASL

Variable OSVR had a static value of 3 and OSFL() did not
actually call _OSI or _OS methods.

The conditional in HDA _INI method of OSVR is dropped and
use of DMA NoSnoop attribute remains disabled to retain
previous behaviour. For soc/amd/picasso a different decision
was made in CB:40782 as HDA _INI method was just dropped and
default configuration enables use of DMA NoSnoop attribute.

Change-Id: I967b7b2afbb43253cccb4b77f6c44db45e2989e4
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50592
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

4 files changed, 6 insertions, 60 deletions

diff --git a/src/southbridge/amd/agesa/hudson/acpi/audio.asl b/src/southbridge/amd/agesa/hudson/acpi/audio.asl
index 8eb0e6d847..58f566e70b 100644
--- a/src/southbridge/amd/agesa/hudson/acpi/audio.asl
+++ b/src/southbridge/amd/agesa/hudson/acpi/audio.asl
@@ -28,11 +28,8 @@ Device(AZHD) {	/* 0:14.2 - HD Audio */
 
 	Method (_INI, 0, NotSerialized)
 	{
-		If (OSVR == 0x03)
-		{
-			NSEN = 0
-			NSDO = 1
-			NSDI = 1
-		}
+		NSEN = 0
+		NSDO = 1
+		NSDI = 1
 	}
 } /* end AZHD */
diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl
index 400f15f4f1..38f2bca6da 100644
--- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl
+++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl
@@ -158,33 +158,9 @@ Method(_INI, 0) {
 	/* DBGO(\_REV) */
 	/* DBGO("\n") */
 
-	/* Determine the OS we're running on */
-	OSFL()
-
 #if CONFIG(HUDSON_IMC_FWM)
 #if CONFIG(ACPI_ENABLE_THERMAL_ZONE)
 	ITZE() /* enable IMC Fan Control*/
 #endif
 #endif
 } /* End Method(_SB._INI) */
-
-Method(OSFL, 0){
-
-	if (OSVR != Ones) {Return (OSVR)}	/* OS version was already detected */
-
-	if (CondRefOf(\_OSI))
-	{
-		OSVR = 1				/* Assume some form of XP */
-		if (\_OSI("Windows 2006"))		/* Vista */
-		{
-			OSVR = 2
-		}
-	} else {
-		If (WCMP(\_OS,"Linux")) {
-			OSVR = 3			/* Linux */
-		} Else {
-			OSVR = 4			/* Gotta be WinCE */
-		}
-	}
-	Return (OSVR)
-}
diff --git a/src/southbridge/amd/pi/hudson/acpi/audio.asl b/src/southbridge/amd/pi/hudson/acpi/audio.asl
index 8eb0e6d847..58f566e70b 100644
--- a/src/southbridge/amd/pi/hudson/acpi/audio.asl
+++ b/src/southbridge/amd/pi/hudson/acpi/audio.asl
@@ -28,11 +28,8 @@ Device(AZHD) {	/* 0:14.2 - HD Audio */
 
 	Method (_INI, 0, NotSerialized)
 	{
-		If (OSVR == 0x03)
-		{
-			NSEN = 0
-			NSDO = 1
-			NSDI = 1
-		}
+		NSEN = 0
+		NSDO = 1
+		NSDI = 1
 	}
 } /* end AZHD */
diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl
index 25b53d3e19..88cf47f7ef 100644
--- a/src/southbridge/amd/pi/hudson/acpi/fch.asl
+++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl
@@ -144,33 +144,9 @@ Method(_INI, 0) {
 	/* DBGO(\_REV) */
 	/* DBGO("\n") */
 
-	/* Determine the OS we're running on */
-	OSFL()
-
 #if CONFIG(HUDSON_IMC_FWM)
 #if CONFIG(ACPI_ENABLE_THERMAL_ZONE)
 	ITZE() /* enable IMC Fan Control*/
 #endif
 #endif
 } /* End Method(_SB._INI) */
-
-Method(OSFL, 0){
-
-	if (OSVR != Ones) {Return (OSVR)}	/* OS version was already detected */
-
-	if (CondRefOf(\_OSI))
-	{
-		OSVR = 1				/* Assume some form of XP */
-		if (\_OSI("Windows 2006"))		/* Vista */
-		{
-			OSVR = 2
-		}
-	} else {
-		If (WCMP(\_OS,"Linux")) {
-			OSVR = 3			/* Linux */
-		} Else {
-			OSVR = 4			/* Gotta be WinCE */
-		}
-	}
-	Return (OSVR)
-}