diff options
| author | Martin Roth <martinroth@google.com> | 2015-12-08 15:04:23 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-10 16:31:35 +0100 |
| commit | 91d9cbc2fbc62ede85e4eae07c52c43ffe7a4eb3 (patch) | |
| tree | a65a35f49c6946ce70760cfad8464719b69c3a8d /src/southbridge | |
| parent | 5a98bf2c0a9c1616e7fc807e0b5d8a2cbcf9062e (diff) | |
ACPI: Fix IASL Warning about unused method for _OSI check
According to the ACPI Spec for CondRefOf, the result argument is
optional. In all of these locations, it was getting set but not
used, creating a warning in new versions of IASL. Since it's
an optional argument, just remove it.
dsdt.aml 22: if(CondRefOf(\_OSI,Local1))
Warning 3144 - ^
Method Local is set but never used (Local1)
Change-Id: I07f49ac5a3708838d1c4a7216dfb11acc415c881
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12692
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/southbridge')
| -rw-r--r-- | src/southbridge/amd/agesa/hudson/acpi/fch.asl | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/pi/hudson/acpi/fch.asl | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/common/acpi/platform.asl | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl index 9351059a4d..d7cee4a0c0 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl @@ -185,7 +185,7 @@ Method(OSFL, 0){ if(LNotEqual(OSVR, Ones)) {Return(OSVR)} /* OS version was already detected */ - if(CondRefOf(\_OSI,Local1)) + if(CondRefOf(\_OSI)) { Store(1, OSVR) /* Assume some form of XP */ if (\_OSI("Windows 2006")) /* Vista */ diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl index 02a272ddf5..5a433e613a 100644 --- a/src/southbridge/amd/pi/hudson/acpi/fch.asl +++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl @@ -167,7 +167,7 @@ Method(OSFL, 0){ if(LNotEqual(OSVR, Ones)) {Return(OSVR)} /* OS version was already detected */ - if(CondRefOf(\_OSI,Local1)) + if(CondRefOf(\_OSI)) { Store(1, OSVR) /* Assume some form of XP */ if (\_OSI("Windows 2006")) /* Vista */ diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl index 8481dfd9b4..ba8091d73b 100644 --- a/src/southbridge/intel/common/acpi/platform.asl +++ b/src/southbridge/intel/common/acpi/platform.asl @@ -70,7 +70,7 @@ Method(GOS, 0) /* Let's assume we're running at least Windows 2000 */ Store (2000, OSYS) - If (CondRefOf(_OSI, Local0)) { + If (CondRefOf(_OSI)) { /* Linux answers _OSI with "True" for a couple of * Windows version queries. But unlike Windows it * needs a Video repost, so let's determine whether |