diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-04-30 05:01:52 +1000 |
|---|---|---|
| committer | Rudolf Marek <r.marek@assembler.cz> | 2014-05-13 10:03:51 +0200 |
| commit | def00be41db96971a92b78f3f23343c344d82c43 (patch) | |
| tree | c83d1f612461e7cd0fb8a96e377e2d250fb191f4 /src/southbridge | |
| parent | e61dd0f7a2be83ce5ba87d74f7384111576ffd49 (diff) | |
src/drivers/pc80: Remove empty struct keyboard
This is a empty struct that has propagated through the superio's & ec's
but really does nothing. Time to get rid of it before it adds yet more
cruft. However, since this touches many superio's at once we do this in
stages by first changing the function type to be a pure procedure.
Change-Id: Ibc732e676a9d4f0269114acabc92b15771d27ef2
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5617
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
Diffstat (limited to 'src/southbridge')
| -rw-r--r-- | src/southbridge/dmp/vortex86ex/southbridge.c | 2 | ||||
| -rw-r--r-- | src/southbridge/sis/sis966/lpc.c | 16 | ||||
| -rw-r--r-- | src/southbridge/via/vt8231/vt8231.c | 2 | ||||
| -rw-r--r-- | src/southbridge/via/vt8235/vt8235.c | 2 | ||||
| -rw-r--r-- | src/southbridge/via/vt8237r/lpc.c | 2 |
5 files changed, 12 insertions, 12 deletions
diff --git a/src/southbridge/dmp/vortex86ex/southbridge.c b/src/southbridge/dmp/vortex86ex/southbridge.c index 2a68e4e4ea..b9432f0260 100644 --- a/src/southbridge/dmp/vortex86ex/southbridge.c +++ b/src/southbridge/dmp/vortex86ex/southbridge.c @@ -611,7 +611,7 @@ static void southbridge_init(struct device *dev) retries--; } post_code(POST_DMP_KBD_IS_READY); - pc_keyboard_init(0); + pc_keyboard_init(); } static struct device_operations vortex_sb_ops = { diff --git a/src/southbridge/sis/sis966/lpc.c b/src/southbridge/sis/sis966/lpc.c index a4db1e5435..824bb6a174 100644 --- a/src/southbridge/sis/sis966/lpc.c +++ b/src/southbridge/sis/sis966/lpc.c @@ -89,16 +89,16 @@ static void lpc_usb_legacy_init(device_t dev) static void lpc_init(device_t dev) { - uint8_t byte; - uint8_t byte_old; - int on; - int nmi_option; + uint8_t byte; + uint8_t byte_old; + int on; + int nmi_option; - printk(BIOS_DEBUG, "LPC_INIT -------->\n"); - pc_keyboard_init(0); + printk(BIOS_DEBUG, "LPC_INIT -------->\n"); + pc_keyboard_init(); - lpc_usb_legacy_init(dev); - lpc_common_init(dev); + lpc_usb_legacy_init(dev); + lpc_common_init(dev); /* power after power fail */ diff --git a/src/southbridge/via/vt8231/vt8231.c b/src/southbridge/via/vt8231/vt8231.c index 85f007a097..2011d8ab83 100644 --- a/src/southbridge/via/vt8231/vt8231.c +++ b/src/southbridge/via/vt8231/vt8231.c @@ -21,7 +21,7 @@ static void keyboard_on(void) regval |= 0x0f; pci_write_config8(lpc_dev, 0x51, regval); } - pc_keyboard_init(0); + pc_keyboard_init(); } static void com_port_on(void) diff --git a/src/southbridge/via/vt8235/vt8235.c b/src/southbridge/via/vt8235/vt8235.c index 4fa2784661..6bc767ae34 100644 --- a/src/southbridge/via/vt8235/vt8235.c +++ b/src/southbridge/via/vt8235/vt8235.c @@ -16,7 +16,7 @@ static void keyboard_on(struct device *dev) regval &= 0xfd; pci_write_config8(dev, 0x51, regval); - pc_keyboard_init(0); + pc_keyboard_init(); } #ifdef UNUSED_CODE diff --git a/src/southbridge/via/vt8237r/lpc.c b/src/southbridge/via/vt8237r/lpc.c index 4949de6560..5ddd816153 100644 --- a/src/southbridge/via/vt8237r/lpc.c +++ b/src/southbridge/via/vt8237r/lpc.c @@ -627,7 +627,7 @@ static void init_keyboard(struct device *dev) { u8 regval = pci_read_config8(dev, 0x51); if (regval & 0x1) - pc_keyboard_init(0); + pc_keyboard_init(); } static void southbridge_init_common(struct device *dev) |