diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2008-10-12 14:40:23 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2008-10-12 14:40:23 +0000 |
commit | 0a20c416226d34ef25881e4d143cf1b8bf531656 (patch) | |
tree | 4063219eef59254c34ef8db6fef59f3d2fc7e1c8 /src/southbridge/via/vt8237r/vt8237r_sata.c | |
parent | 2e5a9d952f3f3d23cf57a08abeffe3dee3444950 (diff) |
VIA VT8237R cleanups (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3651 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/via/vt8237r/vt8237r_sata.c')
-rw-r--r-- | src/southbridge/via/vt8237r/vt8237r_sata.c | 34 |
1 files changed, 20 insertions, 14 deletions
diff --git a/src/southbridge/via/vt8237r/vt8237r_sata.c b/src/southbridge/via/vt8237r/vt8237r_sata.c index 77d7b0c3e2..a445476265 100644 --- a/src/southbridge/via/vt8237r/vt8237r_sata.c +++ b/src/southbridge/via/vt8237r/vt8237r_sata.c @@ -39,37 +39,43 @@ static void sata_i_init(struct device *dev) pci_write_config8(dev, PCI_CLASS_DEVICE, 0x1); reg |= 0x80; /* Sub Class Write Protect on */ pci_write_config8(dev, SATA_MISC_CTRL, reg); - + return; } -static void sata_ii_init(struct device *dev) { +static void sata_ii_init(struct device *dev) +{ u8 reg; sata_i_init(dev); - - /* analog black magic, you may or may not need to adjust 0x60-0x6f, depends on PCB */ - - /* Analog PHY - gen1 + + /* + * Analog black magic, you may or may not need to adjust 0x60-0x6f, + * depends on PCB. + */ + + /* + * Analog PHY - gen1 * CDR bandwidth [6:5] = 3 * Squelch Window Select [4:3] = 1 * CDR Charge Pump [2:0] = 1 */ - + pci_write_config8(dev, 0x64, 0x49); - - /* adjust driver current source value to 9 */ + + /* Adjust driver current source value to 9. */ reg = pci_read_config8(dev, 0x65); reg &= 0xf0; reg |= 0x9; pci_write_config8(dev, 0x65, reg); - - /* set all manual termination 50ohm bits [2:0] and enable [4] */ + + /* Set all manual termination 50ohm bits [2:0] and enable [4]. */ reg = pci_read_config8(dev, 0x6a); reg |= 0xf; pci_write_config8(dev, 0x6a, reg); - /* Analog PHY - gen2 + /* + * Analog PHY - gen2 * CDR bandwidth [5:4] = 2 * Pre / De-emphasis Level [7:6] controls bits [3:2], rest in 0x6e * CDR Charge Pump [2:0] = 1 @@ -80,10 +86,10 @@ static void sata_ii_init(struct device *dev) { reg |= 0x61; pci_write_config8(dev, 0x6f, reg); - /* check if staggered spinup is supported */ + /* Check if staggered spinup is supported. */ reg = pci_read_config8(dev, 0x83); if ((reg & 0x8) == 0) { - /* start OOB sequence on both drives */ + /* Start OOB sequence on both drives. */ reg |= 0x30; pci_write_config8(dev, 0x83, reg); } |