diff options
author | Tobias Diedrich <ranma+coreboot@tdiedrich.de> | 2010-11-14 14:12:14 +0000 |
---|---|---|
committer | Rudolf Marek <r.marek@assembler.cz> | 2010-11-14 14:12:14 +0000 |
commit | d441afda9106d000ff1d518bad01e98cfb26630e (patch) | |
tree | afebdc883a3aa5cb09ace2b0ac8031cd65189aee /src/southbridge/via/vt8237r/vt8237r_ide.c | |
parent | f3cce2f3c4ff4af4a386bddd49c92a55ad9cefa2 (diff) |
Currently the
cablesel |= (sb->ide0_80pin_cable << 28) |
(sb->ide0_80pin_cable << 20) |
(sb->ide1_80pin_cable << 12) |
(sb->ide1_80pin_cable << 4);
in vt8237r_ide.c ends up doing
cablesel |= 0xfffffff0;
(with both bits set to 1) which is probably not the intended result. ;)
After a short discussion on irc the consensus was to change the
bitfields to u8 as it's probably not worth it using bitfields here.
Signed-off-by: Tobias Diedrich <ranma+coreboot@tdiedrich.de>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6068 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/via/vt8237r/vt8237r_ide.c')
0 files changed, 0 insertions, 0 deletions