diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-06-13 13:45:42 +0300 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-06-16 08:01:55 +0000 |
| commit | 94464474756f0cacdf04a70b95ec4a0462516a63 (patch) | |
| tree | 95d042373ec67650529d7eea8c273de903edeac5 /src/southbridge/intel/i82801ix | |
| parent | f3973bd4cf83b41a2fb37806948b6dbccfbf367a (diff) | |
sb/intel: Clean up some SMI enables
Change-Id: I191ad709fd3c6f906cd34b0053eeaebdb80d410d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42354
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/southbridge/intel/i82801ix')
| -rw-r--r-- | src/southbridge/intel/i82801ix/lpc.c | 8 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801ix/smi.c | 9 |
2 files changed, 4 insertions, 13 deletions
diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 11c153f4e7..732e69a385 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -228,12 +228,8 @@ static void i82801ix_power_options(struct device *dev) // another laptop wants this? // reg16 &= ~(1 << 10); // BIOS_PCI_EXP_EN - Desktop/Mobile only reg16 |= (1 << 10); // BIOS_PCI_EXP_EN - Desktop/Mobile only -#if DEBUG_PERIODIC_SMIS - /* Set DEBUG_PERIODIC_SMIS in i82801ix.h to debug using - * periodic SMIs. - */ - reg16 |= (3 << 0); // Periodic SMI every 8s -#endif + if (CONFIG(DEBUG_PERIODIC_SMI)) + reg16 |= (3 << 0); // Periodic SMI every 8s if (config->c5_enable) reg16 |= (1 << 11); /* Enable C5, C6 and PMSYNC# */ pci_write_config16(dev, D31F0_GEN_PMCON_1, reg16); diff --git a/src/southbridge/intel/i82801ix/smi.c b/src/southbridge/intel/i82801ix/smi.c index b8611d0fec..2bbac886ce 100644 --- a/src/southbridge/intel/i82801ix/smi.c +++ b/src/southbridge/intel/i82801ix/smi.c @@ -69,15 +69,10 @@ static void aseg_smm_relocate(void) */ smi_en = 0; /* reset SMI enables */ - smi_en |= TCO_EN; smi_en |= APMC_EN; -#if DEBUG_PERIODIC_SMIS - /* Set DEBUG_PERIODIC_SMIS in i82801ix.h to debug using - * periodic SMIs. - */ - smi_en |= PERIODIC_EN; -#endif + if (CONFIG(DEBUG_PERIODIC_SMI)) + smi_en |= PERIODIC_EN; smi_en |= BIOS_EN; /* The following need to be on for SMIs to happen */ |