diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 13:01:01 -0800 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-01-06 20:15:20 +0100 |
| commit | 5ab52ddc3dc289267b603c0a348c461d336aeaf5 (patch) | |
| tree | 7ebe9f17e224426ad570028ec12188e165617517 /src/southbridge/intel/i82801dx | |
| parent | 65b72ab55d7dff1f13cdf495d345e04e634b97ac (diff) | |
southbridge: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the southbridge code to use printk() on all non-ROMCC
boards.
Change-Id: I312406257e66bbdc3940e206b5256460559a2c98
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8110
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/southbridge/intel/i82801dx')
| -rw-r--r-- | src/southbridge/intel/i82801dx/early_smbus.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/southbridge/intel/i82801dx/early_smbus.c b/src/southbridge/intel/i82801dx/early_smbus.c index 6f4d4f8846..c61de85e5d 100644 --- a/src/southbridge/intel/i82801dx/early_smbus.c +++ b/src/southbridge/intel/i82801dx/early_smbus.c @@ -28,7 +28,7 @@ void enable_smbus(void) { device_t dev = PCI_DEV(0x0, 0x1f, 0x3); - print_debug("SMBus controller enabled\n"); + printk(BIOS_DEBUG, "SMBus controller enabled\n"); /* set smbus iobase */ pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1); /* Set smbus enable */ @@ -104,9 +104,9 @@ int smbus_read_byte(unsigned device, unsigned address) unsigned char global_status_register; unsigned char byte; - /* print_err("smbus_read_byte\n"); */ + /* printk(BIOS_ERR, "smbus_read_byte\n"); */ if (smbus_wait_until_ready() < 0) { - print_err("SMBUS not ready (-2)\n"); + printk(BIOS_ERR, "SMBUS not ready (-2)\n"); return -2; } @@ -132,13 +132,13 @@ int smbus_read_byte(unsigned device, unsigned address) SMBUS_IO_BASE + SMBHSTCTL); /* poll for it to start */ if (smbus_wait_until_active() < 0) { - print_err("SMBUS not active (-4)\n"); + printk(BIOS_ERR, "SMBUS not active (-4)\n"); return -4; } /* poll for transaction completion */ if (smbus_wait_until_done() < 0) { - print_err("SMBUS not completed (-3)\n"); + printk(BIOS_ERR, "SMBUS not completed (-3)\n"); return -3; } @@ -148,10 +148,10 @@ int smbus_read_byte(unsigned device, unsigned address) byte = inb(SMBUS_IO_BASE + SMBHSTDAT0); if (global_status_register != 2) { - //print_spew("%s: no device (%02x, %02x)\n", __func__, device, address); + //printk(BIOS_SPEW, "%s: no device (%02x, %02x)\n", __func__, device, address); return -1; } - //print_debug("%s: %02x@%02x = %02x\n", __func__, device, address, byte); + //printk(BIOS_DEBUG, "%s: %02x@%02x = %02x\n", __func__, device, address, byte); return byte; } |