summaryrefslogtreecommitdiff
path: root/src/southbridge/intel/i82801dx
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-10-30 17:36:16 +0100
committerAngel Pons <th3fanbus@gmail.com>2020-11-07 14:18:20 +0000
commit4b519f7c62d55b06c1d99ee6b39a0226475777ad (patch)
treef413f852122f395bc70793572956a80b5e8cbf9b /src/southbridge/intel/i82801dx
parent344a1bd43c63dbfeb3cff04e63d531f32242aba4 (diff)
sb/intel/*/lpc.c: Don't try to write read-only PCICMD bits
For all these southbridges, the lower nibble of PCICMD is read-only. Tested on Asrock B85M Pro4 (Lynxpoint-H), LPC's PCICMD does not change. Change-Id: Ib3b16b1b9651f7f3bd06ff8bc27dafd8a323e93c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47038 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/southbridge/intel/i82801dx')
-rw-r--r--src/southbridge/intel/i82801dx/lpc.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/southbridge/intel/i82801dx/lpc.c b/src/southbridge/intel/i82801dx/lpc.c
index dec12666fc..f207c11556 100644
--- a/src/southbridge/intel/i82801dx/lpc.c
+++ b/src/southbridge/intel/i82801dx/lpc.c
@@ -252,11 +252,6 @@ static void enable_hpet(struct device *dev)
static void lpc_init(struct device *dev)
{
- /* Set the value for PCI command register. */
- pci_write_config16(dev, PCI_COMMAND,
- PCI_COMMAND_MASTER | PCI_COMMAND_SPECIAL |
- PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
-
i82801dx_enable_acpi(dev);
/* IO APIC initialization. */
i82801dx_enable_ioapic(dev);