summaryrefslogtreecommitdiff
path: root/src/southbridge/intel/i82371eb
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2020-04-04 12:26:35 +0200
committerNico Huber <nico.h@gmx.de>2020-04-05 13:31:28 +0000
commitdeeccbf4e96de1cd4ed136f865b96a90db374886 (patch)
treeb81adfab9c6375bf75196226995aa78e2da247ec /src/southbridge/intel/i82371eb
parent7c45c8363d86280d70cb671ea713a06fd462a6e7 (diff)
Drop explicit NULL initializations from `device_operations`
Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside that, the struct has grown over the years. There are too many optional fields to list them all. Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge/intel/i82371eb')
-rw-r--r--src/southbridge/intel/i82371eb/ide.c4
-rw-r--r--src/southbridge/intel/i82371eb/isa.c1
-rw-r--r--src/southbridge/intel/i82371eb/smbus.c1
-rw-r--r--src/southbridge/intel/i82371eb/usb.c2
4 files changed, 0 insertions, 8 deletions
diff --git a/src/southbridge/intel/i82371eb/ide.c b/src/southbridge/intel/i82371eb/ide.c
index b21887f8d9..40e74e93ab 100644
--- a/src/southbridge/intel/i82371eb/ide.c
+++ b/src/southbridge/intel/i82371eb/ide.c
@@ -146,8 +146,6 @@ static const struct device_operations ide_ops_fb_sb = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = ide_init_i82371fb_sb,
- .scan_bus = 0,
- .enable = 0,
.ops_pci = 0, /* No subsystem IDs on 82371XX! */
};
@@ -157,8 +155,6 @@ static const struct device_operations ide_ops_ab_eb_mb = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = ide_init_i82371ab_eb_mb,
- .scan_bus = 0,
- .enable = 0,
.ops_pci = 0, /* No subsystem IDs on 82371XX! */
};
diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c
index 7fe243f1d5..bb876115a3 100644
--- a/src/southbridge/intel/i82371eb/isa.c
+++ b/src/southbridge/intel/i82371eb/isa.c
@@ -135,7 +135,6 @@ static const struct device_operations isa_ops = {
#endif
.init = isa_init,
.scan_bus = scan_static_bus,
- .enable = 0,
.ops_pci = 0, /* No subsystem IDs on 82371EB! */
};
diff --git a/src/southbridge/intel/i82371eb/smbus.c b/src/southbridge/intel/i82371eb/smbus.c
index f9690c34ad..d74879d0b6 100644
--- a/src/southbridge/intel/i82371eb/smbus.c
+++ b/src/southbridge/intel/i82371eb/smbus.c
@@ -113,7 +113,6 @@ static const struct device_operations smbus_ops = {
.read_resources = pwrmgt_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
- .init = 0,
.scan_bus = scan_smbus,
.enable = pwrmgt_enable,
.ops_pci = 0, /* No subsystem IDs on 82371EB! */
diff --git a/src/southbridge/intel/i82371eb/usb.c b/src/southbridge/intel/i82371eb/usb.c
index d4fffa4619..4fcd26cc98 100644
--- a/src/southbridge/intel/i82371eb/usb.c
+++ b/src/southbridge/intel/i82371eb/usb.c
@@ -37,8 +37,6 @@ static const struct device_operations usb_ops = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = usb_init,
- .scan_bus = 0,
- .enable = 0,
.ops_pci = 0, /* No subsystem IDs on 82371EB! */
};