diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-06-13 13:45:42 +0300 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-06-16 08:01:55 +0000 |
| commit | 94464474756f0cacdf04a70b95ec4a0462516a63 (patch) | |
| tree | 95d042373ec67650529d7eea8c273de903edeac5 /src/southbridge/intel/common/smi.c | |
| parent | f3973bd4cf83b41a2fb37806948b6dbccfbf367a (diff) | |
sb/intel: Clean up some SMI enables
Change-Id: I191ad709fd3c6f906cd34b0053eeaebdb80d410d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42354
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/southbridge/intel/common/smi.c')
| -rw-r--r-- | src/southbridge/intel/common/smi.c | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/src/southbridge/intel/common/smi.c b/src/southbridge/intel/common/smi.c index 80d43a5210..e5af3f136d 100644 --- a/src/southbridge/intel/common/smi.c +++ b/src/southbridge/intel/common/smi.c @@ -12,8 +12,6 @@ #include "pmutil.h" -#define DEBUG_PERIODIC_SMIS 0 - u16 get_pmbase(void) { return lpc_get_pmbase(); @@ -60,28 +58,16 @@ void smm_southbridge_enable_smi(void) * - on TCO events * - on APMC writes (io 0xb2) * - on writes to SLP_EN (sleep states) - * - on writes to GBL_RLS (bios commands) * No SMIs: * - on microcontroller writes (io 0x62/0x66) */ smi_en = 0; /* reset SMI enables */ - -#if 0 - smi_en |= LEGACY_USB2_EN | LEGACY_USB_EN; -#endif smi_en |= TCO_EN; smi_en |= APMC_EN; -#if DEBUG_PERIODIC_SMIS - /* Set DEBUG_PERIODIC_SMIS in pch.h to debug using - * periodic SMIs. - */ - smi_en |= PERIODIC_EN; -#endif + if (CONFIG(DEBUG_PERIODIC_SMI)) + smi_en |= PERIODIC_EN; smi_en |= SLP_SMI_EN; -#if 0 - smi_en |= BIOS_EN; -#endif /* The following need to be on for SMIs to happen */ smi_en |= EOS | GBL_SMI_EN; |