diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2018-06-29 10:34:37 +0200 |
|---|---|---|
| committer | Patrick Rudolph <siro@das-labor.org> | 2018-07-27 16:19:53 +0000 |
| commit | ed3242e33874bd16e33cba8366f48c722f8cbee3 (patch) | |
| tree | bb0cbf4f2d8af09a377f1a11fb4c0e10a1478d23 /src/southbridge/intel/common/smi.c | |
| parent | 853bb4dc11f999d3f5637769da588fbd9446aba8 (diff) | |
sb/intel/common/smi*: Use new PMBASE API
Use new PMBASE API functions in common SMI handler.
Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/27281
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/southbridge/intel/common/smi.c')
| -rw-r--r-- | src/southbridge/intel/common/smi.c | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/src/southbridge/intel/common/smi.c b/src/southbridge/intel/common/smi.c index deaecb2625..d8e6d43a18 100644 --- a/src/southbridge/intel/common/smi.c +++ b/src/southbridge/intel/common/smi.c @@ -23,16 +23,15 @@ #include <cpu/x86/cache.h> #include <cpu/x86/smm.h> #include <cpu/intel/smm/gen1/smi.h> +#include <southbridge/intel/common/pmbase.h> #include "pmutil.h" #define DEBUG_PERIODIC_SMIS 0 -static u16 pmbase; - u16 get_pmbase(void) { - return pmbase; + return lpc_get_pmbase(); } void southbridge_smm_init(void) @@ -48,12 +47,9 @@ void southbridge_smm_init(void) printk(BIOS_DEBUG, "Initializing southbridge SMI..."); - pmbase = pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x1f, 0)), - D31F0_PMBASE) & 0xff80; - - printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", pmbase); + printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", lpc_get_pmbase()); - smi_en = inl(pmbase + SMI_EN); + smi_en = read_pmbase32(SMI_EN); if (smi_en & APMC_EN) { printk(BIOS_INFO, "SMI# handler already enabled?\n"); return; @@ -67,14 +63,14 @@ void southbridge_smm_init(void) dump_tco_status(reset_tco_status()); /* Disable GPE0 PME_B0 */ - gpe0_en = inl(pmbase + GPE0_EN); + gpe0_en = read_pmbase32(GPE0_EN); gpe0_en &= ~PME_B0_EN; - outl(gpe0_en, pmbase + GPE0_EN); + write_pmbase32(GPE0_EN, gpe0_en); pm1_en = 0; pm1_en |= PWRBTN_EN; pm1_en |= GBL_EN; - outw(pm1_en, pmbase + PM1_EN); + write_pmbase16(PM1_EN, pm1_en); /* Enable SMI generation: * - on TCO events @@ -106,7 +102,7 @@ void southbridge_smm_init(void) /* The following need to be on for SMIs to happen */ smi_en |= EOS | GBL_SMI_EN; - outl(smi_en, pmbase + SMI_EN); + write_pmbase32(SMI_EN, smi_en); } void southbridge_trigger_smi(void) |