summaryrefslogtreecommitdiff
path: root/src/southbridge/amd/agesa
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2021-03-15 14:56:16 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-02-16 21:29:53 +0000
commitfff20212afe2c83af90dbec39d112a31d34b6658 (patch)
treeed5d0de6ca1aac63822c479428e1ca63bdf14748 /src/southbridge/amd/agesa
parent97a0d61f0d1d5a9280ba72e2e50d87e4b853777f (diff)
Use the fallthrough statement in switch loops
Clang does not seem to work with 'fall through' in comments. Change-Id: Idcbe373be33ef7247548f856bfaba7ceb7f749b5 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51498 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/southbridge/amd/agesa')
-rw-r--r--src/southbridge/amd/agesa/hudson/hudson.c6
-rw-r--r--src/southbridge/amd/agesa/hudson/lpc.c4
2 files changed, 5 insertions, 5 deletions
diff --git a/src/southbridge/amd/agesa/hudson/hudson.c b/src/southbridge/amd/agesa/hudson/hudson.c
index f1506bc44f..3c34e98d4d 100644
--- a/src/southbridge/amd/agesa/hudson/hudson.c
+++ b/src/southbridge/amd/agesa/hudson/hudson.c
@@ -79,7 +79,7 @@ void hudson_enable(struct device *dev)
case PCI_DEVFN(0x12, 0):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_12_0);
- /* fall through */
+ __fallthrough;
case PCI_DEVFN(0x12, 2):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_12_2);
@@ -87,7 +87,7 @@ void hudson_enable(struct device *dev)
case PCI_DEVFN(0x13, 0):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_13_0);
- /* fall through */
+ __fallthrough;
case PCI_DEVFN(0x13, 2):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_13_2);
@@ -95,7 +95,7 @@ void hudson_enable(struct device *dev)
case PCI_DEVFN(0x16, 0):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_16_0);
- /* fall through */
+ __fallthrough;
case PCI_DEVFN(0x16, 2):
if (dev->enabled == 0)
hudson_disable_usb(USB_EN_DEVFN_16_2);
diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c
index 9bf928ec56..6a31fbfbf8 100644
--- a/src/southbridge/amd/agesa/hudson/lpc.c
+++ b/src/southbridge/amd/agesa/hudson/lpc.c
@@ -290,10 +290,10 @@ static void hudson_lpc_enable_childrens_resources(struct device *dev)
switch (var_num) {
case 3:
pci_write_config16(dev, 0x90, reg_var[2]);
- /* fall through */
+ __fallthrough;
case 2:
pci_write_config16(dev, 0x66, reg_var[1]);
- /* fall through */
+ __fallthrough;
case 1:
pci_write_config16(dev, 0x64, reg_var[0]);
break;