diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2021-10-12 21:39:27 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-12-08 00:30:07 +0000 |
| commit | 6ebcdf38724bd1c89cb5e769b54cb50b302b3062 (patch) | |
| tree | 4a96aaf887b38b7698ac48d2ff5d120b5d8b0773 /src/soc | |
| parent | c90d406008c2bd0b947a11530218c0652fd63b55 (diff) | |
soc/amd: use KiB and MiB definitions
Use KiB and MiB instead of multiplying/dividing with/by the numeric
value when doing region size calculations.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I56c380190b11aa3214cce31b82974327e3d15000
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59936
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/amd/common/block/iommu/iommu.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/common/block/lpc/lpc.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/picasso/agesa_acpi.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index b6e4ac2346..8628096aee 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -14,7 +14,7 @@ static void iommu_read_resources(struct device *dev) /* Add an extra subtractive resource for both memory and I/O. */ res = new_resource(dev, 0x44); - res->size = 512 * 1024; + res->size = 512 * KiB; res->align = log2(res->size); res->gran = log2(res->size); res->limit = 0xffffffff; /* 4G */ diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 7c466459e6..ebded6b87a 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -106,7 +106,7 @@ static void lpc_read_resources(struct device *dev) IORESOURCE_ASSIGNED | IORESOURCE_FIXED; /* Add a memory resource for the SPI BAR. */ - fixed_mem_resource(dev, 2, SPI_BASE_ADDRESS / 1024, 1, + fixed_mem_resource(dev, 2, SPI_BASE_ADDRESS / KiB, 1, IORESOURCE_SUBTRACTIVE); res = new_resource(dev, 3); /* IOAPIC */ diff --git a/src/soc/amd/picasso/agesa_acpi.c b/src/soc/amd/picasso/agesa_acpi.c index 782600754a..4ab31e5229 100644 --- a/src/soc/amd/picasso/agesa_acpi.c +++ b/src/soc/amd/picasso/agesa_acpi.c @@ -82,7 +82,7 @@ static unsigned long gen_crat_memory_entries(struct acpi_crat_header *crat, if (memory_base == 0) { current = create_crat_memory_entry(0, 0ull, 0xa0000ull, current); - memory_base = (1 * 1024 * 1024); + memory_base = 1 * MiB; memory_length = memory_base; new_entries++; } |