summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorAseda Aboagye <aaboagye@google.com>2021-06-17 12:10:33 -0700
committerKarthik Ramasubramanian <kramasub@google.com>2021-06-19 00:06:41 +0000
commit633560568d5cc24da52f1089f0ae4ca362f7de2f (patch)
treec2fee280ebda2cd1c248d88af6d5540c3cf4cee4 /src/soc
parent4291c82ac0a27a803d3229114c56e5442bd0945c (diff)
soc/intel/common/block/smm: Add `mainboard_smi_finalize`
This commit adds a method called `mainboard_smi_finalize` which provides a mechanism for a mainboard to execute some code as part of the finalize method in the SMM stage before SoC does its finalization. BUG=b:191189275 BRANCH=None TEST=Implement `mainboard_smi_finalize` on lalala and verify that the code executes in SMM. Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: If1ee63431e3c2a5831a4656c3a361229acff3f42 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55649 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/common/block/smm/smihandler.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c
index ff87d71e4f..91142a51ce 100644
--- a/src/soc/intel/common/block/smm/smihandler.c
+++ b/src/soc/intel/common/block/smm/smihandler.c
@@ -320,6 +320,13 @@ static void finalize(void)
/* Re-init SPI driver to handle locked BAR */
fast_spi_init();
+ /*
+ * HECI is disabled in smihandler_soc_at_finalize() which also locks down the side band
+ * interface. Some boards may require this interface in mainboard_smi_finalize(),
+ * therefore, this call must precede smihandler_soc_at_finalize().
+ */
+ mainboard_smi_finalize();
+
/* Specific SOC SMI handler during ramstage finalize phase */
smihandler_soc_at_finalize();
}