diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-12-05 19:06:55 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-12-17 20:25:09 +0000 |
| commit | 2e0053b84098512c5b3c98394998e66a8f83803b (patch) | |
| tree | 14eeb88ab35e53010f17ae01eda093665dd88c3b /src/soc | |
| parent | a1a317ebf65c63017e02d017284f8564facaa1c4 (diff) | |
azalia: Use `azalia_enter_reset` function
Also tidy up some adjacent comments.
Change-Id: I2e881900a52e42ab3f43ffe96cfbdcc63ff02e23
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48358
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/common/hda_verb.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/soc/intel/common/hda_verb.c b/src/soc/intel/common/hda_verb.c index 5a4b467b8a..f4ef756d5f 100644 --- a/src/soc/intel/common/hda_verb.c +++ b/src/soc/intel/common/hda_verb.c @@ -24,7 +24,7 @@ int hda_codec_detect(u8 *base) write8(base + HDA_STATESTS_REG, 0xf); /* Turn off the link and poll RESET# bit until it reads back as 0 */ - if (azalia_set_bits(base + HDA_GCTL_REG, HDA_GCTL_CRST, 0) < 0) + if (azalia_enter_reset(base) < 0) goto no_codec; /* Turn on the link and poll RESET# bit until it reads back as 1 */ @@ -40,9 +40,8 @@ int hda_codec_detect(u8 *base) return reg8; no_codec: - /* Codec Not found */ - /* Put HDA back in reset (BAR + 0x8) [0] */ - azalia_set_bits(base + HDA_GCTL_REG, HDA_GCTL_CRST, 0); + /* Codec not found, put HDA back in reset */ + azalia_enter_reset(base); printk(BIOS_DEBUG, "HDA: No codec!\n"); return 0; } |