summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorFelix Held <felix.held@amd.corp-partner.google.com>2021-10-20 20:45:28 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-10-21 20:52:23 +0000
commit250988d943c322ac1720ae7cd6f88592f82a08c0 (patch)
treefd5fd4eb5e50af84c95a12d6882c78e2ea552317 /src/soc
parent30f703148839663a7d41ff72a22be3a9b49110d7 (diff)
soc/amd/common/block/cpu/smm/finalize: simplify finalize_cores
The local variable int r isn't needed, so remove it. This is a preparation to change the return type of mp_run_on_all_cpus from int to enum cb_err which will be done in a follow-up patch. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ie4c454cbfcc581be41ea3463ea6f852a72886128 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58493 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/amd/common/block/cpu/smm/finalize.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/soc/amd/common/block/cpu/smm/finalize.c b/src/soc/amd/common/block/cpu/smm/finalize.c
index 2df55247cf..2795100d86 100644
--- a/src/soc/amd/common/block/cpu/smm/finalize.c
+++ b/src/soc/amd/common/block/cpu/smm/finalize.c
@@ -29,11 +29,9 @@ static void per_core_finalize(void *unused)
static void finalize_cores(void)
{
- int r;
printk(BIOS_SPEW, "Lock SMM configuration\n");
- r = mp_run_on_all_cpus(per_core_finalize, NULL);
- if (r)
+ if (mp_run_on_all_cpus(per_core_finalize, NULL))
printk(BIOS_WARNING, "Failed to finalize all cores\n");
}