summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-07-26 09:03:25 -0600
committerMartin Roth <martinroth@google.com>2016-08-10 23:11:22 +0200
commita7a9c463fd4cecd4152868fdd760030bf8970e43 (patch)
tree7e8fafb5ffd943545da83a2c788487fc77501549 /src/soc
parent5e07a7e474eb2ceeb252ddc33fb26fe041425c1b (diff)
rockchip/common: Set weekday to unknown in rtc_get()
Prior to this patch, time->wday was not being initialized in rtc_get(), but was still being used by rtc_display() to print a day. Set to -1 which gets printed as "unknown ". Fixes coverity issue 1357459 - Uninitialized scalar variable Change-Id: Idecb7968f854df997b58a342e1a06a879f299394 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/15899 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/rockchip/common/rk808.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/rockchip/common/rk808.c b/src/soc/rockchip/common/rk808.c
index 562e76b720..dc6b2ea23f 100644
--- a/src/soc/rockchip/common/rk808.c
+++ b/src/soc/rockchip/common/rk808.c
@@ -199,5 +199,7 @@ int rtc_get(struct rtc_time *time)
ret |= rk808_read(RTC_YEAR, &value);
time->year = bcd2bin(value);
+ time->wday = -1; /* unknown */
+
return ret;
}