diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-01-20 22:53:42 +0100 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2021-01-24 12:07:07 +0000 |
| commit | 24e4edb37696baa13dbf55724051f173224a0d28 (patch) | |
| tree | 0f7f53757bfb915a6ad24a261eb3d2e76a8e93ed /src/soc | |
| parent | 65f81a7b9024290b9b92bda6d1d67ab805fa3986 (diff) | |
soc/intel/broadwell: Drop `struct romstage_params`
It is no longer necessary.
Change-Id: Ib37c9de83badc6339dca6916aec8c34a43797652
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49777
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/broadwell/include/soc/romstage.h | 6 | ||||
| -rw-r--r-- | src/soc/intel/broadwell/romstage.c | 22 |
2 files changed, 11 insertions, 17 deletions
diff --git a/src/soc/intel/broadwell/include/soc/romstage.h b/src/soc/intel/broadwell/include/soc/romstage.h index 9f4eef2316..ebef2c8e52 100644 --- a/src/soc/intel/broadwell/include/soc/romstage.h +++ b/src/soc/intel/broadwell/include/soc/romstage.h @@ -5,12 +5,6 @@ #include <soc/pei_data.h> -struct chipset_power_state; -struct romstage_params { - struct chipset_power_state *power_state; - struct pei_data pei_data; -}; - void mainboard_fill_spd_data(struct pei_data *pei_data); void mainboard_post_raminit(const int s3resume); diff --git a/src/soc/intel/broadwell/romstage.c b/src/soc/intel/broadwell/romstage.c index 76e1d7e47b..d33156e575 100644 --- a/src/soc/intel/broadwell/romstage.c +++ b/src/soc/intel/broadwell/romstage.c @@ -26,7 +26,7 @@ __weak void mainboard_post_raminit(const int s3resume) /* Entry from cpu/intel/car/romstage.c. */ void mainboard_romstage_entry(void) { - struct romstage_params rp = { 0 }; + struct pei_data pei_data = { 0 }; post_code(0x30); @@ -37,9 +37,9 @@ void mainboard_romstage_entry(void) pch_early_init(); /* Get power state */ - rp.power_state = fill_power_state(); + struct chipset_power_state *const power_state = fill_power_state(); - elog_boot_notify(rp.power_state->prev_sleep_state == ACPI_S3); + elog_boot_notify(power_state->prev_sleep_state == ACPI_S3); /* Print useful platform information */ report_platform_info(); @@ -50,28 +50,28 @@ void mainboard_romstage_entry(void) /* Initialize GPIOs */ init_gpios(mainboard_gpio_config); - mainboard_fill_pei_data(&rp.pei_data); - mainboard_fill_spd_data(&rp.pei_data); + mainboard_fill_pei_data(&pei_data); + mainboard_fill_spd_data(&pei_data); post_code(0x32); timestamp_add_now(TS_BEFORE_INITRAM); - rp.pei_data.boot_mode = rp.power_state->prev_sleep_state; + pei_data.boot_mode = power_state->prev_sleep_state; /* Print ME state before MRC */ intel_me_status(); /* Save ME HSIO version */ - intel_me_hsio_version(&rp.power_state->hsio_version, - &rp.power_state->hsio_checksum); + intel_me_hsio_version(&power_state->hsio_version, + &power_state->hsio_checksum); /* Initialize RAM */ - raminit(&rp.pei_data); + raminit(&pei_data); timestamp_add_now(TS_AFTER_INITRAM); - romstage_handoff_init(rp.power_state->prev_sleep_state == ACPI_S3); + romstage_handoff_init(power_state->prev_sleep_state == ACPI_S3); - mainboard_post_raminit(rp.power_state->prev_sleep_state == ACPI_S3); + mainboard_post_raminit(power_state->prev_sleep_state == ACPI_S3); } |