diff options
| author | Furquan Shaikh <furquan@google.com> | 2021-01-02 00:15:23 -0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-01-08 08:24:38 +0000 |
| commit | d3b7e2f94af63a42e25738a67c92eb949f520d3d (patch) | |
| tree | 10595c3462d6f1a8b3c50353fb6f7e1d43329ff4 /src/soc | |
| parent | fb29ca0c551dce18546b440ea98bf6bc8101c800 (diff) | |
soc/intel/common/uart: Restrict scope of uart_common_init to uart.c
uart_common_init is not used outside of
soc/intel/common/block/uart.c. This change restricts the scope to this
file and drops the declaration from uart.h
Change-Id: I499a53506f9b2e91ecc7334bf9b023d342e802fc
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49211
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/common/block/include/intelblocks/uart.h | 6 | ||||
| -rw-r--r-- | src/soc/intel/common/block/uart/uart.c | 2 |
2 files changed, 1 insertions, 7 deletions
diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h index 87fdf68868..fd65f4c85e 100644 --- a/src/soc/intel/common/block/include/intelblocks/uart.h +++ b/src/soc/intel/common/block/include/intelblocks/uart.h @@ -24,12 +24,6 @@ struct uart_gpio_pad_config { */ /* - * Common routine to initialize UART controller PCI config space, take it out of - * reset and configure M/N dividers. - */ -void uart_common_init(const struct device *dev, uintptr_t baseaddr); - -/* * Check if UART debug controller is initialized * Returns: * true = If debug controller PCI config space is initialized and device is diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index 75c16d4625..1e205ef07f 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -58,7 +58,7 @@ static int uart_get_valid_index(void) return UART_CONSOLE_INVALID_INDEX; } -void uart_common_init(const struct device *device, uintptr_t baseaddr) +static void uart_common_init(const struct device *device, uintptr_t baseaddr) { #if defined(__SIMPLE_DEVICE__) pci_devfn_t dev = PCI_BDF(device); |