summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-14 15:09:45 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-10-18 14:20:28 +0000
commitb54388df63f1a42b623e01ec03476712b4a08710 (patch)
tree7e11996c134b0f89b094958d49bdb2501938cc3b /src/soc
parent9ae922abf728814e10781a71f35803bd53d57524 (diff)
ACPI: Have common acpi_fill_mcfg()
As long as there is only one PCI segment we do not need more complicated MCFG generation. Change-Id: Ic2a8e84383883039bb7f994227e2e425366f9e13 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50666 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/amd/common/block/acpi/tables.c12
-rw-r--r--src/soc/intel/baytrail/acpi.c7
-rw-r--r--src/soc/intel/braswell/acpi.c7
-rw-r--r--src/soc/intel/broadwell/acpi.c8
-rw-r--r--src/soc/intel/common/block/acpi/acpi.c9
-rw-r--r--src/soc/intel/denverton_ns/acpi.c9
-rw-r--r--src/soc/intel/quark/acpi.c5
7 files changed, 0 insertions, 57 deletions
diff --git a/src/soc/amd/common/block/acpi/tables.c b/src/soc/amd/common/block/acpi/tables.c
index 8bad755de1..ec484a9781 100644
--- a/src/soc/amd/common/block/acpi/tables.c
+++ b/src/soc/amd/common/block/acpi/tables.c
@@ -17,18 +17,6 @@ unsigned long southbridge_write_acpi_tables(const struct device *device,
return acpi_write_hpet(device, current, rsdp);
}
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
-
- current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
- CONFIG_MMCONF_BASE_ADDRESS,
- 0,
- 0,
- CONFIG_MMCONF_BUS_NUMBER - 1);
-
- return current;
-}
-
unsigned long acpi_fill_madt_irqoverride(unsigned long current)
{
const struct soc_amd_common_config *cfg = soc_get_common_config();
diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c
index b91134fe20..e6c5abfcd3 100644
--- a/src/soc/intel/baytrail/acpi.c
+++ b/src/soc/intel/baytrail/acpi.c
@@ -86,13 +86,6 @@ int acpi_sci_irq(void)
return sci_irq;
}
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
- current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
- CONFIG_MMCONF_BASE_ADDRESS, 0, 0, CONFIG_MMCONF_BUS_NUMBER - 1);
- return current;
-}
-
unsigned long acpi_fill_madt(unsigned long current)
{
/* Local APICs */
diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c
index 757358d0f5..d37799c92c 100644
--- a/src/soc/intel/braswell/acpi.c
+++ b/src/soc/intel/braswell/acpi.c
@@ -108,13 +108,6 @@ int acpi_sci_irq(void)
return sci_irq;
}
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
- current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
- CONFIG_MMCONF_BASE_ADDRESS, 0, 0, CONFIG_MMCONF_BUS_NUMBER - 1);
- return current;
-}
-
static acpi_tstate_t soc_tss_table[] = {
{ 100, 1000, 0, 0x00, 0 },
{ 88, 875, 0, 0x1e, 0 },
diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c
index 512f9f3d46..00e6807bd5 100644
--- a/src/soc/intel/broadwell/acpi.c
+++ b/src/soc/intel/broadwell/acpi.c
@@ -21,14 +21,6 @@
#include <soc/systemagent.h>
#include <soc/intel/broadwell/chip.h>
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
- current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
- CONFIG_MMCONF_BASE_ADDRESS, 0, 0,
- CONFIG_MMCONF_BUS_NUMBER - 1);
- return current;
-}
-
static unsigned long acpi_fill_dmar(unsigned long current)
{
struct device *const igfx_dev = pcidev_path_on_root(SA_DEVFN_IGD);
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c
index 6f7412740a..f144a6d5fa 100644
--- a/src/soc/intel/common/block/acpi/acpi.c
+++ b/src/soc/intel/common/block/acpi/acpi.c
@@ -23,15 +23,6 @@
#define CPUID_6_EAX_ISST (1 << 7)
-__attribute__((weak)) unsigned long acpi_fill_mcfg(unsigned long current)
-{
- /* PCI Segment Group 0, Start Bus Number 0, End Bus Number is 255 */
- current += acpi_create_mcfg_mmconfig((void *)current,
- CONFIG_MMCONF_BASE_ADDRESS, 0, 0,
- CONFIG_MMCONF_BUS_NUMBER - 1);
- return current;
-}
-
static int acpi_sci_irq(void)
{
int sci_irq = 9;
diff --git a/src/soc/intel/denverton_ns/acpi.c b/src/soc/intel/denverton_ns/acpi.c
index a28da48134..b8b793e4df 100644
--- a/src/soc/intel/denverton_ns/acpi.c
+++ b/src/soc/intel/denverton_ns/acpi.c
@@ -81,15 +81,6 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
return cstate_map;
}
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
- /* PCI Segment Group 0, Start Bus Number 0, End Bus Number is 255 */
- current += acpi_create_mcfg_mmconfig((void *)current,
- CONFIG_MMCONF_BASE_ADDRESS, 0, 0,
- CONFIG_MMCONF_BUS_NUMBER - 1);
- return current;
-}
-
void soc_fill_fadt(acpi_fadt_t *fadt)
{
u16 pmbase = get_pmbase();
diff --git a/src/soc/intel/quark/acpi.c b/src/soc/intel/quark/acpi.c
index fc96fb6c3b..9ea62bbcdb 100644
--- a/src/soc/intel/quark/acpi.c
+++ b/src/soc/intel/quark/acpi.c
@@ -10,11 +10,6 @@ unsigned long acpi_fill_madt(unsigned long current)
return current;
}
-unsigned long acpi_fill_mcfg(unsigned long current)
-{
- return current;
-}
-
void acpi_fill_fadt(acpi_fadt_t *fadt)
{
struct device *dev = pcidev_on_root(PCI_DEVICE_NUMBER_QNC_LPC,