diff options
| author | Appukuttan V K <appukuttan.vk@intel.com> | 2024-04-02 17:26:25 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-04-22 14:52:15 +0000 |
| commit | 2d89c7821744de70e5bddd3a1659dd43c4be5d4e (patch) | |
| tree | 0869811ff047f4fb01470f010d402aeb519977a5 /src/soc | |
| parent | b55000b2d5975f2355936c99b5b732ae4b9da3d3 (diff) | |
drivers/intel/fsp2_0: Introduce fsp print helper macros
This patch introduces fsp print helper macros to print
`efi_return_status_t' with the appropriate format. These macros
are now used for fsp debug prints with return status
efi_return_status_t is defined as UINT64 or UNIT32 based on the
selected architecture
BUG=b:329034258
TEST=Verified on Meteor Lake board (Rex)
Change-Id: If6342c4d40c76b702351070e424797c21138a4a9
Signed-off-by: Appukuttan V K <appukuttan.vk@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81630
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/amd/common/fsp/fsp_reset.c | 5 | ||||
| -rw-r--r-- | src/soc/intel/common/fsp_reset.c | 6 |
2 files changed, 5 insertions, 6 deletions
diff --git a/src/soc/amd/common/fsp/fsp_reset.c b/src/soc/amd/common/fsp/fsp_reset.c index 0a89dc728a..761ba2bdbb 100644 --- a/src/soc/amd/common/fsp/fsp_reset.c +++ b/src/soc/amd/common/fsp/fsp_reset.c @@ -6,10 +6,9 @@ #include <fsp/util.h> #include <stdint.h> -void chipset_handle_reset(uint32_t status) +void chipset_handle_reset(efi_return_status_t status) { - printk(BIOS_ERR, "unexpected call to %s(0x%08x). Doing cold reset.\n", - __func__, status); + fsp_printk(status, BIOS_ERR, "Doing cold reset due to unexpected call to %s", __func__); BUG(); do_cold_reset(); } diff --git a/src/soc/intel/common/fsp_reset.c b/src/soc/intel/common/fsp_reset.c index 2bb39bd5a3..2626c39413 100644 --- a/src/soc/intel/common/fsp_reset.c +++ b/src/soc/intel/common/fsp_reset.c @@ -30,20 +30,20 @@ struct fsp_reset_hob { struct pch_reset_data reset_data; }; -void chipset_handle_reset(uint32_t status) +void chipset_handle_reset(efi_return_status_t status) { if (status == CONFIG_FSP_STATUS_GLOBAL_RESET) { printk(BIOS_DEBUG, "GLOBAL RESET!\n"); global_reset(); } - printk(BIOS_ERR, "unhandled reset type %x\n", status); + fsp_printk(status, BIOS_ERR, "unhandled reset type"); die("unknown reset type"); } static uint32_t fsp_reset_type_to_status(EFI_RESET_TYPE reset_type) { - uint32_t status; + efi_return_status_t status; switch (reset_type) { case EfiResetCold: |