summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2023-08-08 13:56:37 +0100
committerShelley Chen <shchen@google.com>2023-12-26 17:05:21 +0000
commit06f4f65d241d1908c5d72cd0455351194ce52ca7 (patch)
treea23cd1bc0e1d08b9b2c5beacd59bf931d431a91d /src/soc
parentb95ef282ff785f63ce2a74ff0140072856893687 (diff)
soc/intel/alderlake: Make C1e configurable
Make it possible to enable C1e from the devicetree by adding `c1e_enable`. C1e was disabled by ea2a38be323173075db3b13729a4006ea1fef72d for all RPL SOCs to reduce noise. This will ensure that boards that disabled it based on CPUID are unchanged. Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: I758621393cb39345c2ba7b19a32872e84e1c5a19 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77088 Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/alderlake/chip.h3
-rw-r--r--src/soc/intel/alderlake/fsp_params.c2
2 files changed, 4 insertions, 1 deletions
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h
index b1e90fa774..2f94db65df 100644
--- a/src/soc/intel/alderlake/chip.h
+++ b/src/soc/intel/alderlake/chip.h
@@ -736,6 +736,9 @@ struct soc_intel_alderlake_config {
*/
bool disable_package_c_state_demotion;
+ /* Enable Enhanced C States */
+ bool enable_c1e;
+
/* i915 struct for GMA backlight control */
struct i915_gpu_controller_info gfx;
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c
index 4ceda50fb4..5edfbcc781 100644
--- a/src/soc/intel/alderlake/fsp_params.c
+++ b/src/soc/intel/alderlake/fsp_params.c
@@ -1070,7 +1070,7 @@ static void fill_fsps_misc_power_params(FSP_S_CONFIG *s_cfg,
s_cfg->PkgCStateDemotion = !config->disable_package_c_state_demotion;
if (cpu_id == CPUID_RAPTORLAKE_J0 || cpu_id == CPUID_RAPTORLAKE_Q0)
- s_cfg->C1e = 0;
+ s_cfg->C1e = config->enable_c1e;
else
s_cfg->C1e = 1;
#if CONFIG(SOC_INTEL_RAPTORLAKE) && !CONFIG(FSP_USE_REPO)