include/console/uart: make index parameter unsigned

The UART index is never negative, so make it unsigned and drop the
checks for the index to be non-negative.

Change-Id: I64bd60bd2a3b82552cb3ac6524792b9ac6c09a94
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45294
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>

2 files changed, 9 insertions, 9 deletions

diff --git a/src/soc/qualcomm/sc7180/qupv3_uart.c b/src/soc/qualcomm/sc7180/qupv3_uart.c
index f9d99bb71e..bf274c23c9 100644
--- a/src/soc/qualcomm/sc7180/qupv3_uart.c
+++ b/src/soc/qualcomm/sc7180/qupv3_uart.c
@@ -34,7 +34,7 @@
 #define UART_RX_PACK_VECTOR0	0xF
 #define UART_RX_PACK_VECTOR2	0x00
 
-void uart_tx_flush(int idx)
+void uart_tx_flush(unsigned int idx)
 {
 	struct qup_regs *regs = qup[idx].regs;
 
@@ -43,7 +43,7 @@ void uart_tx_flush(int idx)
 		;
 }
 
-void uart_init(int idx)
+void uart_init(unsigned int idx)
 {
 	struct qup_regs *regs = qup[idx].regs;
 	unsigned int reg_value;
@@ -113,7 +113,7 @@ void uart_init(int idx)
 	write32(&regs->geni_s_cmd0, START_UART_RX);
 }
 
-unsigned char uart_rx_byte(int idx)
+unsigned char uart_rx_byte(unsigned int idx)
 {
 	struct qup_regs *regs = qup[idx].regs;
 
@@ -122,7 +122,7 @@ unsigned char uart_rx_byte(int idx)
 	return 0;
 }
 
-void uart_tx_byte(int idx, unsigned char data)
+void uart_tx_byte(unsigned int idx, unsigned char data)
 {
 	struct qup_regs *regs = qup[idx].regs;
 
@@ -134,7 +134,7 @@ void uart_tx_byte(int idx, unsigned char data)
 	write32(&regs->geni_tx_fifon, data);
 }
 
-uintptr_t uart_platform_base(int idx)
+uintptr_t uart_platform_base(unsigned int idx)
 {
 	return (uintptr_t)qup[idx].regs;
 }
diff --git a/src/soc/qualcomm/sc7180/uart_bitbang.c b/src/soc/qualcomm/sc7180/uart_bitbang.c
index b3a6cd5870..7d88a20986 100644
--- a/src/soc/qualcomm/sc7180/uart_bitbang.c
+++ b/src/soc/qualcomm/sc7180/uart_bitbang.c
@@ -16,22 +16,22 @@ static void set_tx(int line_state)
 	gpio_set(UART_TX_PIN, line_state);
 }
 
-void uart_init(int idx)
+void uart_init(unsigned int idx)
 {
 	gpio_output(UART_TX_PIN, 1);
 }
 
-void uart_tx_byte(int idx, unsigned char data)
+void uart_tx_byte(unsigned int idx, unsigned char data)
 {
 	uart_bitbang_tx_byte(data, set_tx);
 }
 
-void uart_tx_flush(int idx)
+void uart_tx_flush(unsigned int idx)
 {
 	/* unnecessary, PIO Tx means transaction is over when tx_byte returns */
 }
 
-unsigned char uart_rx_byte(int idx)
+unsigned char uart_rx_byte(unsigned int idx)
 {
 	return 0;	/* not implemented */
 }