treewide: Remove "ERROR: "/"WARN: " prefixes from log messages

Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.

This patch was created by running

  find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'

and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with

  's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>

4 files changed, 8 insertions, 8 deletions

diff --git a/src/soc/qualcomm/common/clock.c b/src/soc/qualcomm/common/clock.c
index 09cd95c88a..e06a954f3c 100644
--- a/src/soc/qualcomm/common/clock.c
+++ b/src/soc/qualcomm/common/clock.c
@@ -27,7 +27,7 @@ enum cb_err clock_enable_vote(void *cbcr_addr, void *vote_addr,
 			return CB_SUCCESS;
 		udelay(1);
 	}
-	printk(BIOS_ERR, "ERROR: Failed to enable clock, register val: 0x%x\n",
+	printk(BIOS_ERR, "Failed to enable clock, register val: 0x%x\n",
 			read32(cbcr_addr));
 	return CB_ERR;
 }
@@ -45,7 +45,7 @@ enum cb_err clock_enable(void *cbcr_addr)
 			return CB_SUCCESS;
 		udelay(1);
 	}
-	printk(BIOS_ERR, "ERROR: Failed to enable clock, register val: 0x%x\n",
+	printk(BIOS_ERR, "Failed to enable clock, register val: 0x%x\n",
 			read32(cbcr_addr));
 	return CB_ERR;
 }
@@ -207,7 +207,7 @@ enum cb_err clock_configure_enable_gpll(struct alpha_pll_reg_val_config *cfg,
 
 		/* Wait for Lock Detection */
 		if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
-			printk(BIOS_ERR, "ERROR: PLL did not lock!\n");
+			printk(BIOS_ERR, "PLL did not lock!\n");
 			return CB_ERR;
 		}
 	}
@@ -227,7 +227,7 @@ enum cb_err agera_pll_enable(struct alpha_pll_reg_val_config *cfg)
 	setbits32(cfg->reg_mode, BIT(PLL_RESET_SHFT));
 
 	if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
-		printk(BIOS_ERR, "ERROR: CPU PLL did not lock!\n");
+		printk(BIOS_ERR, "CPU PLL did not lock!\n");
 		return CB_ERR;
 	}
 
@@ -249,7 +249,7 @@ enum cb_err zonda_pll_enable(struct alpha_pll_reg_val_config *cfg)
 	setbits32(cfg->reg_opmode, PLL_RUN_MODE);
 
 	if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
-		printk(BIOS_ERR, "ERROR: CPU PLL did not lock!\n");
+		printk(BIOS_ERR, "CPU PLL did not lock!\n");
 		return CB_ERR;
 	}
 
diff --git a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c
index fc560ffae7..c1782be790 100644
--- a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c
+++ b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c
@@ -408,7 +408,7 @@ void ss_qmp_phy_init(void)
 			!(read32(&ss_phy_reg->qmp_pcs_reg->pcs_ready_status) &
 			USB3_PCS_PHYSTATUS));
 	if (!lock_us)
-		printk(BIOS_ERR, "ERROR: QMP PHY PLL LOCK fails:\n");
+		printk(BIOS_ERR, "QMP PHY PLL LOCK fails:\n");
 	else
 		printk(BIOS_DEBUG, "QMP PHY initialized and locked in %ldus\n",
 				lock_us);
diff --git a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c
index 031e2cfb2b..23ab75ad2a 100644
--- a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c
+++ b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c
@@ -404,7 +404,7 @@ void ss_qmp_phy_init(void)
 			!(read32(&ss_phy_reg->qmp_pcs_reg->pcs_ready_status) &
 			USB3_PCS_PHYSTATUS));
 	if (!lock_us)
-		printk(BIOS_ERR, "ERROR: QMP PHY PLL LOCK fails:\n");
+		printk(BIOS_ERR, "QMP PHY PLL LOCK fails:\n");
 	else
 		printk(BIOS_DEBUG, "QMP PHY initialized and locked in %ldus\n",
 				lock_us);
diff --git a/src/soc/qualcomm/common/usb/qusb_phy.c b/src/soc/qualcomm/common/usb/qusb_phy.c
index c8a56b019a..494f7cd3b3 100644
--- a/src/soc/qualcomm/common/usb/qusb_phy.c
+++ b/src/soc/qualcomm/common/usb/qusb_phy.c
@@ -132,7 +132,7 @@ void hs_usb_phy_init(void *board_data)
 	long lock_us = wait_us(160, read32(&hs_phy_reg->phy_dig->debug_stat5) &
 						VSTATUS_PLL_LOCK_STATUS_MASK);
 	if (!lock_us)
-		printk(BIOS_ERR, "ERROR: QUSB PHY PLL LOCK fails\n");
+		printk(BIOS_ERR, "QUSB PHY PLL LOCK fails\n");
 	else
 		printk(BIOS_DEBUG, "QUSB PHY initialized and locked in %ldus\n",
 				lock_us);