treewide: Remove "ERROR: "/"WARN: " prefixes from log messages

Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.

This patch was created by running

  find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'

and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with

  's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>

7 files changed, 10 insertions, 10 deletions

diff --git a/src/soc/mediatek/common/include/soc/msdc.h b/src/soc/mediatek/common/include/soc/msdc.h
index b7f7fd7b0b..798b0f61fe 100644
--- a/src/soc/mediatek/common/include/soc/msdc.h
+++ b/src/soc/mediatek/common/include/soc/msdc.h
@@ -162,7 +162,7 @@ struct msdc_ctrlr {
 
 #define msdc_debug(format...) printk(BIOS_DEBUG, format)
 #define msdc_trace(format...) printk(BIOS_DEBUG, format)
-#define msdc_error(format...) printk(BIOS_ERR, "ERROR: " format)
+#define msdc_error(format...) printk(BIOS_ERR, format)
 
 int mtk_emmc_early_init(void *base, void *top_base);
 void mtk_msdc_configure_emmc(bool is_early_init);
diff --git a/src/soc/mediatek/mt8173/da9212.c b/src/soc/mediatek/mt8173/da9212.c
index e44a76f592..5028f18792 100644
--- a/src/soc/mediatek/mt8173/da9212.c
+++ b/src/soc/mediatek/mt8173/da9212.c
@@ -46,7 +46,7 @@ static void da9212_hw_init(uint8_t i2c_num, unsigned char variant_id)
 			       DA9212_BUCK_MODE_MASK, DA9212_BUCK_MODE_SHIFT);
 
 	if (ret)
-		printk(BIOS_ERR, "ERROR: %s failed\n", __func__);
+		printk(BIOS_ERR, "%s failed\n", __func__);
 
 }
 
@@ -74,7 +74,7 @@ void da9212_probe(uint8_t i2c_num)
 
 	/* Check device ID is DA9212 */
 	if (device_id != DA9212_ID || ret) {
-		printk(BIOS_ERR, "ERROR: unknown DA9212 device_id\n");
+		printk(BIOS_ERR, "unknown DA9212 device_id\n");
 		return;
 	}
 
diff --git a/src/soc/mediatek/mt8173/mt6311.c b/src/soc/mediatek/mt8173/mt6311.c
index 3e61f8c399..05149dc46c 100644
--- a/src/soc/mediatek/mt8173/mt6311.c
+++ b/src/soc/mediatek/mt8173/mt6311.c
@@ -97,7 +97,7 @@ static void mt6311_hw_init(uint8_t i2c_num)
 			       MT6311_LDO_CON3, 0, 0x1, 0);
 
 	if (ret)
-		printk(BIOS_ERR, "ERROR: %s failed\n", __func__);
+		printk(BIOS_ERR, "%s failed\n", __func__);
 }
 
 void mt6311_probe(uint8_t i2c_num)
@@ -109,7 +109,7 @@ void mt6311_probe(uint8_t i2c_num)
 	printk(BIOS_INFO, "%s: device ID = %#x\n", __func__, val);
 
 	if (val < MT6311_E1_CID_CODE) {
-		printk(BIOS_ERR, "ERROR: unknown MT6311 device_id\n");
+		printk(BIOS_ERR, "unknown MT6311 device_id\n");
 		return;
 	}
 
diff --git a/src/soc/mediatek/mt8195/dpm_4ch.c b/src/soc/mediatek/mt8195/dpm_4ch.c
index 78895c8466..f13337d8b7 100644
--- a/src/soc/mediatek/mt8195/dpm_4ch.c
+++ b/src/soc/mediatek/mt8195/dpm_4ch.c
@@ -28,7 +28,7 @@ static int wake_dpm_sram_up(void)
 	}
 
 	if (loop == 0) {
-		printk(BIOS_ERR, "ERROR: failed to wake DPM up.\n");
+		printk(BIOS_ERR, "failed to wake DPM up.\n");
 		return -1;
 	}
 
diff --git a/src/soc/mediatek/mt8195/dptx.c b/src/soc/mediatek/mt8195/dptx.c
index edb3f7ef3a..f2c0905cc4 100644
--- a/src/soc/mediatek/mt8195/dptx.c
+++ b/src/soc/mediatek/mt8195/dptx.c
@@ -431,7 +431,7 @@ static void dptx_setsdp_downcnt_init_inhblanking(struct mtk_dp *mtk_dp)
 			 0x08 : 0x00;
 		if (pixclk_mhz > mtk_dp->train_info.linkrate * 27) {
 			count = 0x8;
-			printk(BIOS_ERR, "ERROR: Pixclk > LinkRateChange\n");
+			printk(BIOS_ERR, "Pixclk > LinkRateChange\n");
 		} else {
 			count = 0x10 + offset;
 		}
diff --git a/src/soc/mediatek/mt8195/dptx_hal.c b/src/soc/mediatek/mt8195/dptx_hal.c
index 385e88cbdb..b246c20119 100644
--- a/src/soc/mediatek/mt8195/dptx_hal.c
+++ b/src/soc/mediatek/mt8195/dptx_hal.c
@@ -719,7 +719,7 @@ void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, int value)
 		mtk_dp_write_byte(mtk_dp, REG_34A4_DP_TRANS_P0,
 				  value << 2, BIT(3) | BIT(2));
 	} else {
-		printk(BIOS_ERR, "ERROR: [%s]value << 2 > 0xff\n", __func__);
+		printk(BIOS_ERR, "[%s]value << 2 > 0xff\n", __func__);
 	}
 }
 
@@ -742,7 +742,7 @@ void dptx_hal_set_txrate(struct mtk_dp *mtk_dp, int value)
 		mtk_dp_write(mtk_dp, 0x103C, 0x3);
 		break;
 	default:
-		printk(BIOS_ERR, "ERROR: Link rate not support(%d)\n", value);
+		printk(BIOS_ERR, "Link rate not support(%d)\n", value);
 		break;
 	}
 
diff --git a/src/soc/mediatek/mt8195/mt6691.c b/src/soc/mediatek/mt8195/mt6691.c
index 3f224215ef..3b3ccf1623 100644
--- a/src/soc/mediatek/mt8195/mt6691.c
+++ b/src/soc/mediatek/mt8195/mt6691.c
@@ -65,7 +65,7 @@ void mt6691_probe(uint8_t i2c_num)
 {
 	/* Check device ID is MT6691 */
 	if (!get_mt6691_chip_id(i2c_num)) {
-		printk(BIOS_ERR, "ERROR: unknown MT6691 chip_id\n");
+		printk(BIOS_ERR, "unknown MT6691 chip_id\n");
 		return;
 	}
 	/* Slew rate 12mV */